[buildbot] Build targets should default to success when no builds are queued
ClosedPublic
Actions

Authored by jasonbcox on Nov 23 2020, 21:08.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2fe36f9fec5e: [buildbot] Build targets should default to success when no builds are queued

Summary

Before this patch, the behavior of build targets without any builds queued is
poorly defined.

This change will be used in a followup diff to ensure a call to /buildDiff
that results in no builds being queued will still succeed.

Test Plan

pytest

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Nov 23 2020, 21:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2020, 21:08

jasonbcox requested review of this revision.Nov 23 2020, 21:08

Harbormaster completed remote builds in B14181: Diff 25988.Nov 23 2020, 21:31

jasonbcox added a child revision: D8509: [buildbot] Set build status as passed when a target has no builds.Nov 23 2020, 21:39

Fabien accepted this revision.Nov 23 2020, 21:43

This revision is now accepted and ready to land.Nov 23 2020, 21:43

Closed by commit rABC2fe36f9fec5e: [buildbot] Build targets should default to success when no builds are queued (authored by jasonbcox). · Explain WhyNov 23 2020, 21:53

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC2fe36f9fec5e: [buildbot] Build targets should default to success when no builds are queued.

Revision Contents
Changeset List

Path

Size

contrib/

buildbot/

build.py

3 lines

test/

test_build.py

4 lines

Diff 25991

View Options

contrib/buildbot/build.py