Differential D8543

[backport#13537] GUI: Peer table: Visualize inbound/outbound state for every row
ClosedPublic
Actions

Authored by majcosta on Nov 27 2020, 20:06.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC48a2aad3c225: [backport#13537] GUI: Peer table: Visualize inbound/outbound state for every row

Summary

4132ad3bf Show symbol for inbound/outbound in peer table (wodry)

Pull request description:

Fixes #13483

The address in the network peer table is prefixed with an up-arrow symbolizing an outbound connection, or an down-array symbolizing an inbound connection. See screenshot.

The user has an easy visual confirmation about the connection direction state. I really like it :)
Impact to columns sorting is grouping by inbound/outbound first, which in my opinion is an advantage, too.
![bildschirmfoto](https://user-images.githubusercontent.com/8447873/41862752-13803eb2-78a5-11e8-9126-a52385f5ec19.png)

Backport of Core PR13537

Test Plan

ninja all
./qt/bitcoin-qt -testnet

enter "Peers" window and look for arrows

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Nov 27 2020, 20:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2020, 20:06

majcosta requested review of this revision.Nov 27 2020, 20:06

teamcity edited the summary of this revision. (Show Details)Nov 27 2020, 20:06

Harbormaster completed remote builds in B14232: Diff 26068.Nov 27 2020, 20:14

Nice use of unicode :)

This revision is now accepted and ready to land.Nov 28 2020, 00:22

Closed by commit rABC48a2aad3c225: [backport#13537] GUI: Peer table: Visualize inbound/outbound state for every row (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by majcosta). · Explain WhyNov 28 2020, 00:49

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC48a2aad3c225: [backport#13537] GUI: Peer table: Visualize inbound/outbound state for every row.

Revision Contents
Changeset List

Path

Size

src/

qt/

peertablemodel.cpp

5 lines

Diff 26073

src/qt/peertablemodel.cpp

Loading...