HomePhabricator
Diffusion Bitcoin ABC 48a2aad3c225

[backport#13537] GUI: Peer table: Visualize inbound/outbound state for every row
48a2aad3c225
Actions

Description

[backport#13537] GUI: Peer table: Visualize inbound/outbound state for every row

Summary:
4132ad3bf Show symbol for inbound/outbound in peer table (wodry)

Pull request description:

Fixes #13483

The address in the network peer table is prefixed with an up-arrow symbolizing an outbound connection, or an down-array symbolizing an inbound connection. See screenshot.

The user has an easy visual confirmation about the connection direction state. I really like it :)
Impact to columns sorting is grouping by inbound/outbound first, which in my opinion is an advantage, too.
![bildschirmfoto](https://user-images.githubusercontent.com/8447873/41862752-13803eb2-78a5-11e8-9126-a52385f5ec19.png)

Backport of Core PR13537

Test Plan:

ninja all
./qt/bitcoin-qt -testnet

enter "Peers" window and look for arrows

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D8543

Details

Provenance
Jonas Schnelli <dev@jonasschnelli.ch>Authored on Jul 1 2018, 08:27
majcostaCommitted on Nov 28 2020, 00:48
majcostaPushed on Nov 28 2020, 00:49
Reviewer
Restricted Project
Differential Revision
D8543: [backport#13537] GUI: Peer table: Visualize inbound/outbound state for every row
Parents
rABC25b6d91103ee: [backport#13082] Tests: don't test against min relay fee information in…
Branches
Unknown
Tags
Unknown

Changes (1)

PathSize
src/
qt/

rABC48a2aad3c225

View Options

src/qt/peertablemodel.cpp

Loading...