Differential D8566

util: Add Assert identity function
ClosedPublic
Actions

Authored by Fabien on Dec 1 2020, 09:49.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC41441cb8ee36: util: Add Assert identity function

Summary

The utility function is primarily useful to dereference pointer types,
which are known to be not null at that time.

For example, the ArgsManager is known to exist when the wallets are
started:
https://github.com/bitcoin/bitcoin/pull/18923/files#diff-fdb2a1a1d8bc790fcddeb6cf5a42ac55R503
. Instead of silently relying on that assumption, Assert can be used to
abort the program and avoid UB should the assumption ever be violated.

Backport of core PR19277.

Depends on D8565.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19277

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14257
Build 28493: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 28492: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 1 2020, 09:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2020, 09:49

Fabien requested review of this revision.Dec 1 2020, 09:49

teamcity edited the summary of this revision. (Show Details)Dec 1 2020, 09:49

Harbormaster completed remote builds in B14257: Diff 26111.Dec 1 2020, 10:05

deadalnix accepted this revision.Dec 1 2020, 15:06

This revision is now accepted and ready to land.Dec 1 2020, 15:06

Closed by commit rABC41441cb8ee36: util: Add Assert identity function (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyDec 1 2020, 16:25

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC41441cb8ee36: util: Add Assert identity function.

Revision Contents
Changeset List

Path

Size

arcanist/

linter/

CheckNonFatalOverAssertInRpc.php

2 lines

src/

8 lines

net_processing.cpp

5 lines

node/

5 lines

rpc/

5 lines

test/

blockfilter_index_tests.cpp

17 lines

checkpoints_tests.cpp

25 lines

miner_tests.cpp

5 lines

util/

6 lines

1 line

setup_common.cpp

4 lines

validation_block_tests.cpp

27 lines

util/

20 lines

1 line

wallet/

test/

wallet_tests.cpp

6 lines

Diff 26111

arcanist/linter/CheckNonFatalOverAssertInRpc.php

Loading...

src/init.cpp

Loading...

src/net_processing.cpp

Loading...

src/node/context.h

Loading...

src/rpc/blockchain.cpp

Loading...

src/test/blockfilter_index_tests.cpp

Loading...

src/test/checkpoints_tests.cpp

Loading...

src/test/miner_tests.cpp

Loading...

src/test/util/mining.cpp

Loading...

src/test/util/setup_common.h

Loading...

src/test/util/setup_common.cpp

Loading...

src/test/validation_block_tests.cpp

Loading...

src/util/check.h

Loading...

src/validation.cpp

Loading...

src/wallet/test/wallet_tests.cpp

Loading...