Paths

Table of Contentst

Differential D8586

Remove g_rpc_chain global
ClosedPublic
Actions

Authored by Fabien on Dec 3 2020, 10:50.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCc6525a59b647: Remove g_rpc_chain global

Summary

Replace with RPC request reference to new WalletContext struct similar
to the existing NodeContext struct and reference.

This PR is a followup to #18740 removing the g_rpc_node global.

Some later PRs will follow this up and move more wallet globals to the
WalletContext struct.

Backport of core PR19096.

Adapted to match our wallet dump RPCs separation.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 3 2020, 10:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 3 2020, 10:50

Fabien requested review of this revision.Dec 3 2020, 10:50

teamcity edited the summary of this revision. (Show Details)Dec 3 2020, 10:50

Harbormaster completed remote builds in B14284: Diff 26164.Dec 3 2020, 11:12

majcosta requested changes to this revision.Dec 3 2020, 13:41

majcosta added a subscriber: majcosta.

majcosta added inline comments.

src/interfaces/wallet.cpp
472 ↗	(On Diff #26164)	what about making this `void registerRpcs(const Span<const CRPCCommand>& commands)` instead?

This revision now requires changes to proceed.Dec 3 2020, 13:41

Make the commands const

And pass by reference

majcosta accepted this revision.Dec 3 2020, 17:20

This revision is now accepted and ready to land.Dec 3 2020, 17:20

Harbormaster completed remote builds in B14297: Diff 26178.Dec 3 2020, 17:21

Harbormaster completed remote builds in B14298: Diff 26179.Dec 3 2020, 17:27

Closed by commit rABCc6525a59b647: Remove g_rpc_chain global (authored by Russell Yanofsky <russ@yanofsky.org>, committed by Fabien). · Explain WhyDec 7 2020, 08:28

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc6525a59b647: Remove g_rpc_chain global.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

38 lines

rpc/

8 lines

wallet/

1 line

32 lines

8 lines

12 lines

8 lines

24 lines

25 lines

Diff 26213

src/interfaces/wallet.cpp

Loading...

src/rpc/request.h

Loading...

src/wallet/CMakeLists.txt

Loading...

src/wallet/context.h

Loading...

src/wallet/context.cpp

Loading...

src/wallet/rpcdump.h

Loading...

src/wallet/rpcdump.cpp

Loading...

src/wallet/rpcwallet.h

Loading...

src/wallet/rpcwallet.cpp

Loading...