Page MenuHomePhabricator

Remove g_rpc_chain global
ClosedPublic

Authored by Fabien on Dec 3 2020, 10:50.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCc6525a59b647: Remove g_rpc_chain global
Summary
Replace with RPC request reference to new WalletContext struct similar
to the existing NodeContext struct and reference.

This PR is a followup to #18740 removing the g_rpc_node global.

Some later PRs will follow this up and move more wallet globals to the
WalletContext struct.

Backport of core PR19096.

Adapted to match our wallet dump RPCs separation.

Test Plan
ninja all check-all

Event Timeline

Fabien requested review of this revision.Dec 3 2020, 10:50
majcosta requested changes to this revision.Dec 3 2020, 13:41
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/interfaces/wallet.cpp
472

what about making this void registerRpcs(const Span<const CRPCCommand>& commands) instead?

This revision now requires changes to proceed.Dec 3 2020, 13:41

Make the commands const

This revision is now accepted and ready to land.Dec 3 2020, 17:20
This revision was automatically updated to reflect the committed changes.