Page MenuHomePhabricator

[avalanche] Specify the proof to be used by the node via config
ClosedPublic

Authored by deadalnix on Dec 6 2020, 01:50.

Details

Summary

As per title. Unused so far.

Depends on D8604

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox added inline comments.
src/init.cpp
1203 ↗(On Diff #26202)

Nit: ...if avalanche is enabled.

But maybe that is well enough implied by the argument name.

jasonbcox requested changes to this revision.Dec 6 2020, 02:07

Functional test would be ideal. Manual test instructions in the test plan at minimum though. Both would be best :)

This revision now requires changes to proceed.Dec 6 2020, 02:07

There's an ava functional test, so at least original behavior still works as expected. Not much more to test here.

This revision is now accepted and ready to land.Dec 6 2020, 02:10