Page MenuHomePhabricator
Differential D8607

[avalanche] Specify the proof to be used by the node via config
ClosedPublic
Actions

Authored by deadalnix on Dec 6 2020, 01:50.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC995d70773735: [avalanche] Specify the proof to be used by the node via config
Summary

As per title. Unused so far.

Depends on D8604

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Dec 6 2020, 01:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 6 2020, 01:50
deadalnix requested review of this revision.Dec 6 2020, 01:50
Harbormaster completed remote builds in B14316: Diff 26202.Dec 6 2020, 02:03
jasonbcox added a subscriber: jasonbcox.Dec 6 2020, 02:05
jasonbcox added inline comments.
src/init.cpp
1203 ↗(On Diff #26202)

Nit: ...if avalanche is enabled.

But maybe that is well enough implied by the argument name.

jasonbcox requested changes to this revision.Dec 6 2020, 02:07

Functional test would be ideal. Manual test instructions in the test plan at minimum though. Both would be best :)

This revision now requires changes to proceed.Dec 6 2020, 02:07
jasonbcox accepted this revision.Dec 6 2020, 02:10

There's an ava functional test, so at least original behavior still works as expected. Not much more to test here.

This revision is now accepted and ready to land.Dec 6 2020, 02:10
Closed by commit rABC995d70773735: [avalanche] Specify the proof to be used by the node via config (authored by deadalnix). · Explain WhyDec 6 2020, 02:17
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC995d70773735: [avalanche] Specify the proof to be used by the node via config.

Revision Contents
Changeset List

PathSize
src/
avalanche/
6 lines
31 lines
7 lines

Diff 26205

View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/init.cpp

Loading...