Page MenuHomePhabricator

[CashTab] Adds webpack aliases and refactor imports
ClosedPublic

Authored by alcipir on Dec 6 2020, 11:01.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCedc50fe424ca: [CashTab] Adds webpack aliases and refactor imports
Summary

Adds webpack and jest aliases, also refactoring imports to replace multiple instances of "../../../" to more readable ones, such as '@components/'.

Test Plan

npm install, npm run test, run all tests, npm run start to run app.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-add-import-alias
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14321
Build 28617: Build Diff
Build 28616: arc lint + arc unit

Event Timeline

alcipir requested review of this revision.Dec 6 2020, 11:01

Why simply not adding src to the path?

Why simply not adding src to the path?

Tried it but simply wont work, not sure exactly why, but webpack loses itself: (running npm start):

./src/components/App.js
Module not found: Can't resolve 'src/components/Configure/Configure'

Something related to module resolution and the way it handles those imports.

This revision is now accepted and ready to land.Dec 10 2020, 01:35