Page MenuHomePhabricator
Differential D8609

[CashTab] Adds webpack aliases and refactor imports
ClosedPublic
Actions

Authored by alcipir on Dec 6 2020, 11:01.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCedc50fe424ca: [CashTab] Adds webpack aliases and refactor imports
Summary

Adds webpack and jest aliases, also refactoring imports to replace multiple instances of "../../../" to more readable ones, such as '@components/'.

Test Plan

npm install, npm run test, run all tests, npm run start to run app.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-add-import-alias
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14321
Build 28617: Build Diff
Build 28616: arc lint + arc unit

Event Timeline

alcipir created this revision.Dec 6 2020, 11:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 6 2020, 11:01
alcipir requested review of this revision.Dec 6 2020, 11:01
Harbormaster completed remote builds in B14321: Diff 26209.Dec 6 2020, 11:01
deadalnix added a subscriber: deadalnix.Dec 6 2020, 13:32

Why simply not adding src to the path?

alcipir added a comment.Dec 7 2020, 21:40
In D8609#198723, @deadalnix wrote:

Why simply not adding src to the path?

Tried it but simply wont work, not sure exactly why, but webpack loses itself: (running npm start):

./src/components/App.js
Module not found: Can't resolve 'src/components/Configure/Configure'

Something related to module resolution and the way it handles those imports.

deadalnix accepted this revision.Dec 10 2020, 01:35
This revision is now accepted and ready to land.Dec 10 2020, 01:35
Closed by commit rABCedc50fe424ca: [CashTab] Adds webpack aliases and refactor imports (authored by alcipir). · Explain WhyDec 16 2020, 21:43
This revision was automatically updated to reflect the committed changes.
alcipir added a commit: rABCedc50fe424ca: [CashTab] Adds webpack aliases and refactor imports.

Revision Contents
Changeset List

PathSize
web/
cashtab/
config/
5 lines
6 lines
src/
components/
16 lines
Common/
4 lines
4 lines
4 lines
4 lines
Configure/
16 lines
OnBoarding/
10 lines
Send/
20 lines
18 lines
Wallet/
2 lines
2 lines
10 lines
__tests__/
2 lines
hooks/
2 lines
8 lines

Diff 26209

View Options

web/cashtab/config/webpack.config.js

Loading...
View Options

web/cashtab/package.json

Loading...
View Options

web/cashtab/src/components/App.js

Loading...
View Options

web/cashtab/src/components/Common/EnhancedInputs.js

Loading...
View Options

web/cashtab/src/components/Common/QRCode.js

Loading...
View Options

web/cashtab/src/components/Common/ScanQRCode.js

Loading...
View Options

web/cashtab/src/components/Common/Ticker.js

Loading...
View Options

web/cashtab/src/components/Configure/Configure.js

Loading...
View Options

web/cashtab/src/components/OnBoarding/OnBoarding.js

Loading...
View Options

web/cashtab/src/components/Send/Send.js

Loading...
View Options

web/cashtab/src/components/Send/SendToken.js

Loading...
View Options

web/cashtab/src/components/Wallet/TokenList.js

Loading...
View Options

web/cashtab/src/components/Wallet/TokenListItem.js

Loading...
View Options

web/cashtab/src/components/Wallet/Wallet.js

Loading...
View Options

web/cashtab/src/components/__tests__/NotFound.test.js

Loading...
View Options

web/cashtab/src/hooks/useBCH.js

Loading...
View Options

web/cashtab/src/hooks/useWallet.js

Loading...