Page MenuHomePhabricator

alcipir (Andre Cabrera)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2020, 23:59 (29 w, 3 d)

Recent Activity

Jan 8 2021

alcipir updated the diff for D8856: [cashtab] Remove autocomplete from address inputs.

rebase

Jan 8 2021, 22:22
alcipir requested review of D8856: [cashtab] Remove autocomplete from address inputs.
Jan 8 2021, 22:17
alcipir accepted D8853: [cashtab] update CI to npm7/node15.
Jan 8 2021, 22:11
alcipir accepted D8849: [cashtab] use npm ci instead of install on CI.
Jan 8 2021, 16:05
alcipir requested changes to D8849: [cashtab] use npm ci instead of install on CI.

Can you add these instructions to the README? (instead of npm install, npm ci)

Jan 8 2021, 13:06

Jan 7 2021

alcipir updated the test plan for D8840: Remove web hosted npm module.
Jan 7 2021, 23:38
alcipir updated the diff for D8840: Remove web hosted npm module.

Fix unit tests for useWallet

Jan 7 2021, 23:27
alcipir accepted D8824: [CI] Run cashtab tests on CI.
Jan 7 2021, 16:29
alcipir added a comment to D8824: [CI] Run cashtab tests on CI.

npm run test runs tests in watch mode, should npm run test:coverage (also checks for threshold violations).

Jan 7 2021, 15:53
alcipir added a comment to D8825: css-loader to highest version without breaking npm start.

On master, removing node_modules and doing another npm install, I get the same errors reported above:

Screen Shot 2021-01-07 at 11.49.09.png (1×1 px, 318 KB)

Jan 7 2021, 14:50
alcipir requested changes to D8811: [cashtab] Upgrade node modules.

Running the test suite after installing packages breaks one of the unit tests: npm run test:coverage

Jan 7 2021, 08:03
alcipir added a comment to D8811: [cashtab] Upgrade node modules.

Shouldn't package.json be changed as well when running npm update?

Jan 7 2021, 07:58
alcipir accepted D8815: [cashtab] Update fbt.
Jan 7 2021, 05:38
alcipir accepted D8817: [cashtab] Downgrade terser-webpack-plugin to use a supported version of webpack.
Jan 7 2021, 05:34
alcipir abandoned D8810: [cashtab] Fix fbt generating translation files.
Jan 7 2021, 05:33

Jan 6 2021

alcipir added reviewers for D8810: [cashtab] Fix fbt generating translation files: deadalnix, josephroyking.
Jan 6 2021, 23:29
alcipir requested review of D8810: [cashtab] Fix fbt generating translation files.
Jan 6 2021, 23:17
alcipir closed D8808: [CashTab] Fix TerserPlugin and other npm packages with vulnerabilities.
Jan 6 2021, 22:10
alcipir committed rABC6b5d4ab6f2f0: [CashTab] Fix TerserPlugin and other npm packages with vulnerabilities (authored by alcipir).
[CashTab] Fix TerserPlugin and other npm packages with vulnerabilities
Jan 6 2021, 22:10
alcipir updated the diff for D8808: [CashTab] Fix TerserPlugin and other npm packages with vulnerabilities.

Updates package-lock.json

Jan 6 2021, 21:58
alcipir updated the test plan for D8808: [CashTab] Fix TerserPlugin and other npm packages with vulnerabilities.
Jan 6 2021, 21:43
alcipir requested review of D8808: [CashTab] Fix TerserPlugin and other npm packages with vulnerabilities.
Jan 6 2021, 21:38
alcipir added a comment to D8807: [cashtab] Move qrcode to react-qr-code.

When we migrate to Expo, we will probably have to use one of its libraries for QR Code scanning, so I think sticking to qrcode.react for now seems fine.

Jan 6 2021, 19:44
alcipir updated the diff for D8765: Refactor from path 145/245 to path 1899 with migration support.

Add unit tests for testnet cases, covering the threshold

Jan 6 2021, 15:42
alcipir updated the diff for D8765: Refactor from path 145/245 to path 1899 with migration support.

Added unit tests for the migration function.

Jan 6 2021, 04:06

Dec 28 2020

alcipir accepted D8761: Support npm pkgs in extension-specific files.
Dec 28 2020, 17:52

Dec 18 2020

alcipir requested review of D8693: [CashTab] Expo - Initial setup with loading and webview. Working only on Android.
Dec 18 2020, 02:32
alcipir abandoned D8625: [CashTab] Add React Native Wrapper.

We will use Expo framework moving forward.

Dec 18 2020, 02:27

Dec 16 2020

alcipir closed D8609: [CashTab] Adds webpack aliases and refactor imports.
Dec 16 2020, 21:43
alcipir committed rABCedc50fe424ca: [CashTab] Adds webpack aliases and refactor imports (authored by alcipir).
[CashTab] Adds webpack aliases and refactor imports
Dec 16 2020, 21:43
alcipir accepted D8677: Update antd to fix design issues.
Dec 16 2020, 12:56

Dec 8 2020

alcipir planned changes to D8625: [CashTab] Add React Native Wrapper.
Dec 8 2020, 20:06
alcipir requested review of D8625: [CashTab] Add React Native Wrapper.
Dec 8 2020, 11:26

Dec 7 2020

alcipir abandoned D8587: [CashTab] Adds fbt strings to Wallet component on CashTab..
Dec 7 2020, 21:41
alcipir added a comment to D8609: [CashTab] Adds webpack aliases and refactor imports.

Why simply not adding src to the path?

Dec 7 2020, 21:40

Dec 6 2020

alcipir closed D8608: [CashTab] Only show console messages if test fails.
Dec 6 2020, 21:02
alcipir committed rABC81333d8c462c: [CashTab] Only show console messages if test fails (authored by alcipir).
[CashTab] Only show console messages if test fails
Dec 6 2020, 21:01
alcipir requested review of D8609: [CashTab] Adds webpack aliases and refactor imports.
Dec 6 2020, 11:01
alcipir updated the summary of D8608: [CashTab] Only show console messages if test fails.
Dec 6 2020, 08:14
alcipir updated the diff for D8608: [CashTab] Only show console messages if test fails.

Fix wrong argument name being passed

Dec 6 2020, 08:11
alcipir requested review of D8608: [CashTab] Only show console messages if test fails.
Dec 6 2020, 08:03

Dec 5 2020

alcipir accepted D8601: Re-enable SLPA transactions in CashTab and fix notification bug.
Dec 5 2020, 03:35
alcipir added a comment to D8601: Re-enable SLPA transactions in CashTab and fix notification bug.

Edited the title and did more extensive tests.
Working fine.

Dec 5 2020, 03:35
alcipir retitled D8601: Re-enable SLPA transactions in CashTab and fix notification bug from Patching BigNumber issues to Re-enable SLPA transactions in CashTab and fix notification bug.
Dec 5 2020, 03:28

Dec 4 2020

alcipir added inline comments to D8587: [CashTab] Adds fbt strings to Wallet component on CashTab..
Dec 4 2020, 17:24
alcipir closed D8559: [CashTab] Add Fbt dependencies, init script and intl to App component.
Dec 4 2020, 14:39
alcipir committed rABCf0a9f67f8329: [CashTab] Add Fbt dependencies, init script and intl to App component (authored by alcipir).
[CashTab] Add Fbt dependencies, init script and intl to App component
Dec 4 2020, 14:38
alcipir added a reviewer for D8587: [CashTab] Adds fbt strings to Wallet component on CashTab.: deadalnix.
Dec 4 2020, 01:34
alcipir added reviewers for D8587: [CashTab] Adds fbt strings to Wallet component on CashTab.: josephroyking, majcosta.
Dec 4 2020, 01:33
alcipir added inline comments to D8601: Re-enable SLPA transactions in CashTab and fix notification bug.
Dec 4 2020, 01:30
alcipir added a comment to D8601: Re-enable SLPA transactions in CashTab and fix notification bug.

If I try to send SLPA tokens without BCHA I get this error:

image.png (240×667 px, 22 KB)

Dec 4 2020, 01:24
alcipir added inline comments to D8601: Re-enable SLPA transactions in CashTab and fix notification bug.
Dec 4 2020, 01:21
alcipir requested changes to D8601: Re-enable SLPA transactions in CashTab and fix notification bug.

Warning still showing up telling the user that sending SLPA is disabled.

Dec 4 2020, 01:18

Dec 3 2020

alcipir requested review of D8587: [CashTab] Adds fbt strings to Wallet component on CashTab..
Dec 3 2020, 12:47
alcipir updated the diff for D8559: [CashTab] Add Fbt dependencies, init script and intl to App component.

Fix description for strings on App component
Fix .gitignore

Dec 3 2020, 02:26
alcipir accepted D8583: Disabling send for SLPA tokens.
Dec 3 2020, 01:41

Dec 2 2020

alcipir added inline comments to D8559: [CashTab] Add Fbt dependencies, init script and intl to App component.
Dec 2 2020, 22:08
alcipir updated the diff for D8559: [CashTab] Add Fbt dependencies, init script and intl to App component.

Removed fbt-easy-setup, that wasn't being used

Dec 2 2020, 22:07
alcipir retitled D8559: [CashTab] Add Fbt dependencies, init script and intl to App component from [CashTab] Add Transifex dependencies and basic setup to CashTab to [CashTab] Add Fbt dependencies, init script and intl to App component.
Dec 2 2020, 07:23
alcipir updated the diff for D8559: [CashTab] Add Fbt dependencies, init script and intl to App component.

Adds fbt dependencies and init script, adds intl on App component (English/Portuguese)

Dec 2 2020, 07:21

Dec 1 2020

alcipir accepted D8573: Docker deployment files and instructions.
Dec 1 2020, 18:38
alcipir updated the summary of D8559: [CashTab] Add Fbt dependencies, init script and intl to App component.
Dec 1 2020, 15:33
alcipir updated the diff for D8559: [CashTab] Add Fbt dependencies, init script and intl to App component.

Adds changes to App component to handle Transifex strings.

Dec 1 2020, 15:32
alcipir retitled D8559: [CashTab] Add Fbt dependencies, init script and intl to App component from Add Transifex dependencies and basic setup to CashTab to [CashTab] Add Transifex dependencies and basic setup to CashTab.
Dec 1 2020, 03:15
alcipir retitled D8559: [CashTab] Add Fbt dependencies, init script and intl to App component from Add Transifex dependencies and basic setup to Add Transifex dependencies and basic setup to CashTab.
Dec 1 2020, 03:14
alcipir requested review of D8559: [CashTab] Add Fbt dependencies, init script and intl to App component.
Dec 1 2020, 03:12

Nov 13 2020

alcipir accepted D8389: [backport#16947] doc: Doxygen-friendly script/descriptor.h comments.
Nov 13 2020, 04:43