Page MenuHomePhabricator

[cashtab] Upgrade node modules
Needs RevisionPublic

Authored by deadalnix on Thu, Jan 7, 00:01.

Details

Reviewers
majcosta
alcipir
Group Reviewers
Restricted Project
Summary

As per title.

Test Plan
Run the app, it still works.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
updatenode
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 14625
Build 29209: Build Diff
Build 29208: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Thu, Jan 7, 06:02

Rebased

Removed @testing-library/react-hooks because it has conflicts, and it doesn't seems liek it is used. It would be good to double check, because everything seems busted around here.

Shouldn't package.json be changed as well when running npm update?

alcipir requested changes to this revision.Thu, Jan 7, 08:03

Running the test suite after installing packages breaks one of the unit tests: npm run test:coverage

This revision now requires changes to proceed.Thu, Jan 7, 08:03

I think this diff is now obsolete. Package updates and dependencies have been handled in other diffs, most recently D8905.