Page MenuHomePhabricator

Moving dev dependencies to dev, removing unused deps, updates some of them
ClosedPublic

Authored by josephroyking on Wed, Jan 13, 18:25.

Details

Summary

Moves dependencies only required to development to devDependencies. Removes artifact dependencies. Updates some of them.


List of updated modules (to latest version):

babel-plugin-named-asset-import
camelcase
dotenv
lint-staged
prettier
sass-loader
css-loader

The previous issue with css-loader breaking npm start appears to have been resolved by the resolution of the React 16 conflict in earlier diffs and updates to other css dependencies.

Test Plan
npm start

Observe app loads correctly, no errors in console
Send a BCHA tx
Send an SLPA tx
Try copying the address to clipboard by clicking on QR code

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

For clarity, here are the packages that were removed vs re-orged:

big.js
browser-image-compression
core-util-is
crypto-js
gh-pages
identity-obj-proxy
jdenticon
react-jdenticon
react-swipeable
semver
majcosta requested changes to this revision.Thu, Jan 14, 04:01
majcosta added a subscriber: majcosta.
majcosta added inline comments.
web/cashtab/package.json
12 ↗(On Diff #26932)

if this version bump was intentional, you should let it be known in the summary. ditto for any others.

This revision now requires changes to proceed.Thu, Jan 14, 04:01

Upgrading css-loader and other dependencies

List of updated modules (to latest version):

babel-plugin-named-asset-import
camelcase
dotenv
lint-staged
prettier
sass-loader
css-loader

The previous issue with css-loader breaking npm startappears to have been resolved by the resolution of the React 16 conflict in earlier diffs and updates to other css dependencies.

majcosta retitled this revision from Moving dev dependencies to dev, removing unused deps to Moving dev dependencies to dev, removing unused deps, updates some of them.Thu, Jan 14, 11:02
majcosta edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Thu, Jan 14, 11:29