Page MenuHomePhabricator
Differential D8811

[cashtab] Upgrade node modules
AbandonedPublic
Actions

Authored by deadalnix on Jan 7 2021, 00:01.

Details

Reviewers
majcosta
alcipir
Group Reviewers
Restricted Project
Summary

As per title.

Test Plan
Run the app, it still works.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
updatenode
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14608
Build 29175: Build Diff
Build 29174: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 7 2021, 00:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2021, 00:01
deadalnix requested review of this revision.Jan 7 2021, 00:01
Harbormaster completed remote builds in B14608: Diff 26700.Jan 7 2021, 00:02
majcosta accepted this revision.Jan 7 2021, 06:02
This revision is now accepted and ready to land.Jan 7 2021, 06:02
deadalnix updated this revision to Diff 26726.Jan 7 2021, 06:12

Rebased

Removed @testing-library/react-hooks because it has conflicts, and it doesn't seems liek it is used. It would be good to double check, because everything seems busted around here.

Harbormaster completed remote builds in B14625: Diff 26726.Jan 7 2021, 06:13
alcipir added a subscriber: alcipir.Jan 7 2021, 07:58

Shouldn't package.json be changed as well when running npm update?

alcipir requested changes to this revision.Jan 7 2021, 08:03

Running the test suite after installing packages breaks one of the unit tests: npm run test:coverage

This revision now requires changes to proceed.Jan 7 2021, 08:03
bytesofman added a subscriber: bytesofman.Jan 14 2021, 12:45

I think this diff is now obsolete. Package updates and dependencies have been handled in other diffs, most recently D8905.

deadalnix abandoned this revision.Jan 22 2021, 23:00

Revision Contents
Changeset List

PathSize
web/
cashtab/
12208 lines

Diff 26700

View Options

web/cashtab/package-lock.json

Loading...