Page MenuHomePhabricator

[CashTab] Adds fbt strings to Wallet component on CashTab.
AbandonedPublic

Authored by alcipir on Dec 3 2020, 12:47.

Details

Reviewers
josephroyking
majcosta
deadalnix
Group Reviewers
Restricted Project
Summary

Adds fbt strings to Wallet component on CashTab.
Uses fbt function coupled with fbt.params function when applicable due to linting issues with JSX.
Depends on D8559

Test Plan

npm install && npm start. Switching browser language to portuguese, for example, should show portuguese strings on the Wallet component.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
transifex-cashtab
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 14285
Build 28545: Build Diff
Build 28544: arc lint + arc unit

Event Timeline

alcipir requested review of this revision.Dec 3 2020, 12:47
deadalnix requested changes to this revision.Dec 4 2020, 16:43
deadalnix added inline comments.
web/cashtab/src/components/Wallet/Wallet.js
179

You are assuming that a specific layout is appropriate for all locales.

192

This mix of JSX and functional style usage is rathr poor style.

This revision now requires changes to proceed.Dec 4 2020, 16:43
web/cashtab/src/components/Wallet/Wallet.js
192

Yep, you're right. The <fbt:params> tag doesn't work with the linter (doesn't allow JSX namespaces, and there is no rule to allow it AFAIK) and disabling linting is not a good idea. However, I think I've come up with a better solution, will update shortly.

alcipir marked an inline comment as not done.Dec 4 2020, 17:24