[CashTab] Adds fbt strings to Wallet component on CashTab.
AbandonedPublic
Actions

Authored by alcipir on Dec 3 2020, 12:47.

Details

Reviewers

bytesofman
majcosta
deadalnix

Group Reviewers

Restricted Project

Summary

Adds fbt strings to Wallet component on CashTab.
Uses fbt function coupled with fbt.params function when applicable due to linting issues with JSX.
Depends on D8559

Test Plan

npm install && npm start. Switching browser language to portuguese, for example, should show portuguese strings on the Wallet component.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

transifex-cashtab

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14285
Build 28545: Build Diff
Build 28544: arc lint + arc unit

Event Timeline

alcipir created this revision.Dec 3 2020, 12:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 3 2020, 12:47

alcipir requested review of this revision.Dec 3 2020, 12:47

Harbormaster completed remote builds in B14285: Diff 26165.Dec 3 2020, 12:47

alcipir added reviewers: bytesofman, majcosta.Dec 4 2020, 01:33

alcipir added a reviewer: deadalnix.

deadalnix requested changes to this revision.Dec 4 2020, 16:43

deadalnix added inline comments.

web/cashtab/src/components/Wallet/Wallet.js
179	You are assuming that a specific layout is appropriate for all locales.
192	This mix of JSX and functional style usage is rathr poor style.

This revision now requires changes to proceed.Dec 4 2020, 16:43

alcipir added inline comments.Dec 4 2020, 17:24

web/cashtab/src/components/Wallet/Wallet.js
192	Yep, you're right. The <fbt:params> tag doesn't work with the linter (doesn't allow JSX namespaces, and there is no rule to allow it AFAIK) and disabling linting is not a good idea. However, I think I've come up with a better solution, will update shortly.