Page MenuHomePhabricator

[cashtab] Fix fbt generating translation files
AbandonedPublic

Authored by alcipir on Wed, Jan 6, 23:17.

Details

Reviewers
deadalnix
josephroyking
Group Reviewers
Restricted Project
Summary

This diff fixes the issue where running the app locally or building it generated the same files but removed a line from them.

Test Plan

Run npm clean-fbts, then npm start and see if the translation files are changed.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-fix-fbt-translations
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 14606
Build 29171: Build Diff
Build 29170: arc lint + arc unit

Event Timeline

alcipir requested review of this revision.Wed, Jan 6, 23:17
deadalnix requested changes to this revision.Thu, Jan 7, 00:00

There is no explanation as to what problem this solves and why does it solve it.

What was the problem with some command being passed the --pretty flag? What does prepare-fbts do?

This revision now requires changes to proceed.Thu, Jan 7, 00:00

There is no explanation as to what problem this solves and why does it solve it.

What was the problem with some command being passed the --pretty flag? What does prepare-fbts do?