Page MenuHomePhabricator

[cashtab] Remove autocomplete from address inputs
ClosedPublic

Authored by alcipir on Fri, Jan 8, 22:17.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC2715083c15db: [cashtab] Remove autocomplete from address inputs
Summary

Removes autocomplete/input history from address input.

Test Plan

npm run start; send amount to address, check if it shows input history/auto complete

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alcipir requested review of this revision.Fri, Jan 8, 22:17

Failed tests logs:

====== CashTab Unit Tests: useBCH hook gets SLP and BCH balances and utxos ======
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 4
+ Received  + 4

@@ -21,11 +21,11 @@
        "satoshis": 546,
        "tokenDocumentHash": "",
        "tokenDocumentUrl": "mint.bitcoin.com",
        "tokenId": "009ff65ef50632111a9661f67d80025481ebc80ced239d32a92705b04d5df8cc",
        "tokenName": "TT",
-       "tokenQty": 7,
+       "tokenQty": "7",
        "tokenTicker": "TTT",
        "tokenType": 1,
        "transactionType": "send",
        "tx_hash": "bb055d815e795d7a4fe41fd67288d71886678e7d1e5ba9ddd7f6daffa5f70ceb",
        "tx_pos": 2,
@@ -42,11 +42,11 @@
        "satoshis": 546,
        "tokenDocumentHash": "",
        "tokenDocumentUrl": "mint.bitcoin.com",
        "tokenId": "2aef6e63edfded1a299e78b529286deea2a6dd5299b6911778c25632d78a9479",
        "tokenName": "pitico",
-       "tokenQty": 99.35,
+       "tokenQty": "99.35",
        "tokenTicker": "PTC",
        "tokenType": 1,
        "transactionType": "send",
        "tx_hash": "88b7dac07cb30566a6264f330bedda690c8dff151c2307692c79e13dc59ca2ba",
        "tx_pos": 2,
@@ -68,11 +68,11 @@
          "satoshis": 546,
          "tokenDocumentHash": "",
          "tokenDocumentUrl": "mint.bitcoin.com",
          "tokenId": "009ff65ef50632111a9661f67d80025481ebc80ced239d32a92705b04d5df8cc",
          "tokenName": "TT",
-         "tokenQty": 7,
+         "tokenQty": "7",
          "tokenTicker": "TTT",
          "tokenType": 1,
          "transactionType": "send",
          "tx_hash": "bb055d815e795d7a4fe41fd67288d71886678e7d1e5ba9ddd7f6daffa5f70ceb",
          "tx_pos": 2,
@@ -94,11 +94,11 @@
          "satoshis": 546,
          "tokenDocumentHash": "",
          "tokenDocumentUrl": "mint.bitcoin.com",
          "tokenId": "2aef6e63edfded1a299e78b529286deea2a6dd5299b6911778c25632d78a9479",
          "tokenName": "pitico",
-         "tokenQty": 99.35,
+         "tokenQty": "99.35",
          "tokenTicker": "PTC",
          "tokenType": 1,
          "transactionType": "send",
          "tx_hash": "88b7dac07cb30566a6264f330bedda690c8dff151c2307692c79e13dc59ca2ba",
          "tx_pos": 2,
    at Object.it (/work/web/cashtab/src/hooks/__tests__/useBCH.test.js:75:24)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Each failure log is accessible here:
CashTab Unit Tests: useBCH hook gets SLP and BCH balances and utxos

majcosta requested changes to this revision.Sat, Jan 9, 05:10
majcosta added a subscriber: majcosta.

can we do that for the seed import textbox too?

This revision now requires changes to proceed.Sat, Jan 9, 05:10
josephroyking added a subscriber: josephroyking.

autocomplete to autoComplete to correct react error, add to mnemonic fields

This revision is now accepted and ready to land.Sun, Jan 10, 07:19