Page MenuHomePhabricator

Remove web hosted npm module
ClosedPublic

Authored by josephroyking on Thu, Jan 7, 20:24.

Details

Reviewers
alcipir
Fabien
Group Reviewers
Restricted Project
Commits
rABC8c026aee8a3b: Remove web hosted npm module
Summary

Remove web hosted npm module for SLP transactions and replace with local install

Test Plan
npm i
npm start

Send a BCHA tx
Send an SLPA tx
Create a wallet
Activate new wallet

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

updates required in useWallet.test.js

Tail of the build log:

  -t abc-base-image-"${HASH}" debian:buster

(cat <<EOF
results() {
  set +e
  shopt -s dotglob nullglob
  mv /work/abc-ci-builds/"cashtab-tests"/* /results
  chown -R ${ME} /work
  chown -R ${ME} /results
  chown -R ${ME} /root/.ccache
}
trap "results" EXIT
export TEAMCITY_VERSION="2019.2.4 (build 72059)"
export BASE_CACHE="/root/abc-depends/cache"
export SDK_ARCHIVE_DIR="/root/abc-depends/osx-sdk"
export SOURCES_PATH="/root/abc-depends/sources"
mkdir -p "/root/abc-depends/cache" "/root/abc-depends/osx-sdk" "/root/abc-depends/sources"
./contrib/teamcity/build-configurations.py "cashtab-tests"
EOF
) > run-command.sh
chmod +x run-command.sh

~/infra/docker/docker-run.sh \
  -a "-v /home/teamcity/.ccache:/root/.ccache -v /home/teamcity/.abc-depends:/root/abc-depends -v "${RESULTS_DIR}":/results" \
  -c run-command.sh /work/run-command.sh abc-base-image-"${HASH}" ./run-command.sh

[20:29:20] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script2712287901979853369
[20:29:20] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/jailed-build
[20:29:20] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[20:29:20] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[20:29:20] :	 [Step 1/1] Building base image for: 98ff1edfd...
[20:29:20] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[20:29:23] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[20:29:23] :	 [Step 1/1] Tag name: abc-base-image-98ff1edfd
[20:29:49]W:	 [Step 1/1] Traceback (most recent call last):
[20:29:49]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 573, in <module>
[20:29:49]W:	 [Step 1/1]     main()
[20:29:49]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 562, in main
[20:29:49]W:	 [Step 1/1]     script_dir, config_path, args.build)
[20:29:49]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 59, in __init__
[20:29:49]W:	 [Step 1/1]     self.load(build_name)
[20:29:49]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 82, in load
[20:29:49]W:	 [Step 1/1]     self.name, list(config.keys())
[20:29:49]W:	 [Step 1/1] AssertionError: cashtab-tests is not a valid build identifier. Valid identifiers are ['templates', 'builds']
[20:29:49]W:	 [Step 1/1] mv: missing destination file operand after '/results'
[20:29:49]W:	 [Step 1/1] Try 'mv --help' for more information.
[20:29:53]W:	 [Step 1/1] Process exited with code 1
[20:29:53]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
[20:29:53]E:	 [Step 1/1] Step Command Line failed
[20:29:54]E: Ant JUnit report watcher
[20:29:54]E:	 [Ant JUnit report watcher] No reports found for paths:
[20:29:54]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[20:29:54]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[20:29:54] : Publishing internal artifacts (5s)
[20:29:59] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[20:29:59] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[20:29:54]W: Publishing artifacts (5s)
[20:29:54] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml]
[20:29:54]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[20:30:00] : Build finished

Tail of the build log:

---------------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
File                       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                                                                                                                                                              
---------------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
All files                  |   25.02 |    20.86 |   21.07 |   25.29 |                                                                                                                                                                                                
 src                       |       0 |        0 |       0 |       0 |                                                                                                                                                                                                
  index.js                 |       0 |        0 |       0 |       0 | 9-26                                                                                                                                                                                           
  serviceWorker.js         |       0 |        0 |       0 |       0 | 1-48                                                                                                                                                                                           
 src/components            |      10 |        0 |   16.67 |      10 |                                                                                                                                                                                                
  App.js                   |       0 |        0 |       0 |       0 | 30-232                                                                                                                                                                                         
  NotFound.js              |     100 |      100 |     100 |     100 |                                                                                                                                                                                                
 src/components/Common     |    31.9 |    44.19 |   25.81 |    31.9 |                                                                                                                                                                                                
  CustomIcons.js           |      75 |      100 |       0 |      75 | 28                                                                                                                                                                                             
  EnhancedInputs.js        |       0 |        0 |       0 |       0 | 9-176                                                                                                                                                                                          
  PrimaryButton.js         |      50 |        0 |       0 |      50 | 58-63                                                                                                                                                                                          
  QRCode.js                |     100 |       95 |     100 |     100 | 20-35                                                                                                                                                                                          
  ScanQRCode.js            |       0 |        0 |       0 |       0 | 9-142                                                                                                                                                                                          
  StyledCollapse.js        |     100 |      100 |     100 |     100 |                                                                                                                                                                                                
  StyledOnBoarding.js      |     100 |      100 |     100 |     100 |                                                                                                                                                                                                
  StyledPage.js            |     100 |      100 |     100 |     100 |                                                                                                                                                                                                
  Ticker.js                |     100 |      100 |     100 |     100 |                                                                                                                                                                                                
 src/components/Configure  |   36.13 |    19.72 |   10.71 |   36.44 |                                                                                                                                                                                                
  Configure.js             |   36.13 |    19.72 |   10.71 |   36.44 | 171-172,176-177,181-182,185-187,194,213-225,233-256,260-266,270-296,300-328,332-340,344-351,362-545                                                                                            
 src/components/OnBoarding |   38.46 |     8.33 |      10 |      40 |                                                                                                                                                                                                
  OnBoarding.js            |   38.46 |     8.33 |      10 |      40 | 40-51,55-74,94-127                                                                                                                                                                             
 src/components/Send       |       0 |        0 |       0 |       0 |                                                                                                                                                                                                
  Send.js                  |       0 |        0 |       0 |       0 | 20-424                                                                                                                                                                                         
  SendToken.js             |       0 |        0 |       0 |       0 | 24-290                                                                                                                                                                                         
 src/components/Wallet     |      90 |    66.04 |    62.5 |      90 |                                                                                                                                                                                                
  TokenList.js             |     100 |      100 |     100 |     100 |                                                                                                                                                                                                
  TokenListItem.js         |     100 |       50 |     100 |     100 | 37                                                                                                                                                                                             
  Wallet.js                |   86.36 |    66.67 |      40 |   86.36 | 162,233-241                                                                                                                                                                                    
 src/hooks                 |   26.89 |    19.85 |   30.48 |   27.03 |                                                                                                                                                                                                
  useAsyncTimeout.js       |   77.78 |       50 |   83.33 |   82.35 | 20,25-26                                                                                                                                                                                       
  useBCH.js                |   56.19 |     37.5 |   70.59 |   55.14 | 26-41,58-59,70-73,93-96,119-127,183,188,225-405,433,467,514,521,523,525,530                                                                                                                    
  useImage.js              |       0 |        0 |       0 |       0 | 1-199                                                                                                                                                                                          
  useInnerScroll.js        |       0 |      100 |       0 |       0 | 3-6                                                                                                                                                                                            
  useInterval.js           |       0 |      100 |       0 |       0 | 3-16                                                                                                                                                                                           
  usePrevious.js           |     100 |      100 |     100 |     100 |                                                                                                                                                                                                
  useWallet.js             |   18.89 |    11.11 |   30.23 |   19.43 | 38-65,71-79,83-87,94-98,113-140,151-223,233-234,264-265,276-282,297,311-332,340-370,381-401,412-512,518-552,561-598,603-652,656-682,691-701,722,751-827,868-1128,1145-1156,1173-1174,1199-1220 
  useWindowDimensions.js   |       0 |      100 |       0 |       0 | 7-28                                                                                                                                                                                           
 src/i18n                  |       0 |      100 |       0 |       0 |                                                                                                                                                                                                
  init.js                  |       0 |      100 |       0 |       0 | 4-11                                                                                                                                                                                           
  locales.js               |       0 |      100 |     100 |       0 | 1                                                                                                                                                                                              
 src/utils                 |   21.62 |        0 |    7.69 |   22.22 |                                                                                                                                                                                                
  GoogleAnalytics.js       |   27.27 |        0 |   14.29 |   28.57 | 9-39,54-60                                                                                                                                                                                     
  context.js               |      50 |      100 |       0 |      50 | 6-7                                                                                                                                                                                            
  debounce.js              |       0 |        0 |       0 |       0 | 4-8                                                                                                                                                                                            
  retry.js                 |       0 |        0 |       0 |       0 | 1-8                                                                                                                                                                                            
---------------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! cashtab@0.1.8 test: `node scripts/test.js "--reporters=jest-junit"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the cashtab@0.1.8 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-01-07T20_42_15_385Z-debug.log
Build cashtab-tests failed with exit code 1

Tail of the build log:

---------------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
File                       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                                                                                                                                                              
---------------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
All files                  |   25.02 |    20.86 |   21.07 |   25.29 |                                                                                                                                                                                                
 src                       |       0 |        0 |       0 |       0 |                                                                                                                                                                                                
  index.js                 |       0 |        0 |       0 |       0 | 9-26                                                                                                                                                                                           
  serviceWorker.js         |       0 |        0 |       0 |       0 | 1-48                                                                                                                                                                                           
 src/components            |      10 |        0 |   16.67 |      10 |                                                                                                                                                                                                
  App.js                   |       0 |        0 |       0 |       0 | 30-232                                                                                                                                                                                         
  NotFound.js              |     100 |      100 |     100 |     100 |                                                                                                                                                                                                
 src/components/Common     |    31.9 |    44.19 |   25.81 |    31.9 |                                                                                                                                                                                                
  CustomIcons.js           |      75 |      100 |       0 |      75 | 28                                                                                                                                                                                             
  EnhancedInputs.js        |       0 |        0 |       0 |       0 | 9-176                                                                                                                                                                                          
  PrimaryButton.js         |      50 |        0 |       0 |      50 | 58-63                                                                                                                                                                                          
  QRCode.js                |     100 |       95 |     100 |     100 | 20-35                                                                                                                                                                                          
  ScanQRCode.js            |       0 |        0 |       0 |       0 | 9-142                                                                                                                                                                                          
  StyledCollapse.js        |     100 |      100 |     100 |     100 |                                                                                                                                                                                                
  StyledOnBoarding.js      |     100 |      100 |     100 |     100 |                                                                                                                                                                                                
  StyledPage.js            |     100 |      100 |     100 |     100 |                                                                                                                                                                                                
  Ticker.js                |     100 |      100 |     100 |     100 |                                                                                                                                                                                                
 src/components/Configure  |   36.13 |    19.72 |   10.71 |   36.44 |                                                                                                                                                                                                
  Configure.js             |   36.13 |    19.72 |   10.71 |   36.44 | 171-172,176-177,181-182,185-187,194,213-225,233-256,260-266,270-296,300-328,332-340,344-351,362-545                                                                                            
 src/components/OnBoarding |   38.46 |     8.33 |      10 |      40 |                                                                                                                                                                                                
  OnBoarding.js            |   38.46 |     8.33 |      10 |      40 | 40-51,55-74,94-127                                                                                                                                                                             
 src/components/Send       |       0 |        0 |       0 |       0 |                                                                                                                                                                                                
  Send.js                  |       0 |        0 |       0 |       0 | 20-424                                                                                                                                                                                         
  SendToken.js             |       0 |        0 |       0 |       0 | 24-290                                                                                                                                                                                         
 src/components/Wallet     |      90 |    66.04 |    62.5 |      90 |                                                                                                                                                                                                
  TokenList.js             |     100 |      100 |     100 |     100 |                                                                                                                                                                                                
  TokenListItem.js         |     100 |       50 |     100 |     100 | 37                                                                                                                                                                                             
  Wallet.js                |   86.36 |    66.67 |      40 |   86.36 | 162,233-241                                                                                                                                                                                    
 src/hooks                 |   26.89 |    19.85 |   30.48 |   27.03 |                                                                                                                                                                                                
  useAsyncTimeout.js       |   77.78 |       50 |   83.33 |   82.35 | 20,25-26                                                                                                                                                                                       
  useBCH.js                |   56.19 |     37.5 |   70.59 |   55.14 | 26-41,58-59,70-73,93-96,119-127,183,188,225-405,433,467,514,521,523,525,530                                                                                                                    
  useImage.js              |       0 |        0 |       0 |       0 | 1-199                                                                                                                                                                                          
  useInnerScroll.js        |       0 |      100 |       0 |       0 | 3-6                                                                                                                                                                                            
  useInterval.js           |       0 |      100 |       0 |       0 | 3-16                                                                                                                                                                                           
  usePrevious.js           |     100 |      100 |     100 |     100 |                                                                                                                                                                                                
  useWallet.js             |   18.89 |    11.11 |   30.23 |   19.43 | 38-65,71-79,83-87,94-98,113-140,151-223,233-234,264-265,276-282,297,311-332,340-370,381-401,412-512,518-552,561-598,603-652,656-682,691-701,722,751-827,868-1128,1145-1156,1173-1174,1199-1220 
  useWindowDimensions.js   |       0 |      100 |       0 |       0 | 7-28                                                                                                                                                                                           
 src/i18n                  |       0 |      100 |       0 |       0 |                                                                                                                                                                                                
  init.js                  |       0 |      100 |       0 |       0 | 4-11                                                                                                                                                                                           
  locales.js               |       0 |      100 |     100 |       0 | 1                                                                                                                                                                                              
 src/utils                 |   21.62 |        0 |    7.69 |   22.22 |                                                                                                                                                                                                
  GoogleAnalytics.js       |   27.27 |        0 |   14.29 |   28.57 | 9-39,54-60                                                                                                                                                                                     
  context.js               |      50 |      100 |       0 |      50 | 6-7                                                                                                                                                                                            
  debounce.js              |       0 |        0 |       0 |       0 | 4-8                                                                                                                                                                                            
  retry.js                 |       0 |        0 |       0 |       0 | 1-8                                                                                                                                                                                            
---------------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! cashtab@0.1.8 test: `node scripts/test.js "--reporters=jest-junit"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the cashtab@0.1.8 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-01-07T20_55_31_928Z-debug.log
Build cashtab-tests failed with exit code 1

Fix unit tests for useWallet

Fabien requested changes to this revision.Fri, Jan 8, 08:24
Fabien added a subscriber: Fabien.
Fabien added inline comments.
web/cashtab/src/hooks/__tests__/useWallet.test.js
8 ↗(On Diff #26770)

This appears to be unused

This revision now requires changes to proceed.Fri, Jan 8, 08:24

Remove unused lines from useWallet.test.js

This revision is now accepted and ready to land.Fri, Jan 8, 13:13