Page MenuHomePhabricator

[Cashtab] Remove console logging when in production environment
Needs RevisionPublic

Authored by alcipir on Sun, May 23, 07:05.

Details

Reviewers
josephroyking
PiRK
majcosta
Group Reviewers
Restricted Project
Summary

Removes console logging when building the production bundle

Test Plan
	   DEVELOPMENT: npm start, check console logs being displayed properly in development.
	   PRODUCTION: npm run build, npm install -g serve, serve -s build, then logging should be disabled

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-drop-console-on-production
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15785
Build 31470: Build Diffcashtab-tests
Build 31469: arc lint + arc unit

Event Timeline

alcipir requested review of this revision.Sun, May 23, 07:05
This revision is now accepted and ready to land.Mon, May 24, 06:32
majcosta requested changes to this revision.Mon, May 24, 16:46
majcosta added a subscriber: majcosta.

no reason to drop this, imho

This revision now requires changes to proceed.Mon, May 24, 16:46

For now, I still have slpBalancesAndUtxos in the console in prod -- it helps for testing in case there is some unforeseen issue.

I can see where this would be useful in the future:

  • Substantially more console.log dev statements are added
  • These are always kept on for dev purposes
  • But all are removed for prod

However, we're not there right now. I think ok to abandon this for now.