[Cashtab] Remove console logging when in production environment
AbandonedPublic
Actions

Authored by bytesofman on May 23 2021, 07:05.

Details

Reviewers

PiRK
majcosta
alcipir

Group Reviewers

Restricted Project

Summary

Removes console logging when building the production bundle

Test Plan

	   DEVELOPMENT: npm start, check console logs being displayed properly in development.
	   PRODUCTION: npm run build, npm install -g serve, serve -s build, then logging should be disabled

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cashtab-drop-console-on-production

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15785
Build 31470: Build Diff	cashtab-tests
Build 31469: arc lint + arc unit

Event Timeline

alcipir created this revision.May 23 2021, 07:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 23 2021, 07:05

alcipir requested review of this revision.May 23 2021, 07:05

alcipir added a reviewer: bytesofman.May 23 2021, 07:06

Harbormaster completed remote builds in B15785: Diff 28574.May 23 2021, 07:08

PiRK accepted this revision.May 24 2021, 06:32

This revision is now accepted and ready to land.May 24 2021, 06:32

no reason to drop this, imho

This revision now requires changes to proceed.May 24 2021, 16:46

For now, I still have slpBalancesAndUtxos in the console in prod -- it helps for testing in case there is some unforeseen issue.

I can see where this would be useful in the future:

Substantially more console.log dev statements are added
These are always kept on for dev purposes
But all are removed for prod

However, we're not there right now. I think ok to abandon this for now.

Good to know this can be done. Won't be landing in the near future.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

config/

webpack.config.js

1 line

Diff 28574

View Options

web/cashtab/config/webpack.config.js

[Cashtab] Remove console logging when in production environmentAbandonedPublicActions