Page MenuHomePhabricator

css-loader to highest version without breaking npm start
AbandonedPublic

Authored by josephroyking on Thu, Jan 7, 13:38.

Details

Reviewers
alcipir
majcosta
deadalnix
Group Reviewers
Restricted Project
Summary

css-loader above 3.6.0 breaks css on npm start

Test Plan
npm i
npm start

Observe Cashtab loads with correct css

Diff Detail

Repository
rABC Bitcoin ABC
Branch
css-loader-downgrade
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 14632
Build 29223: Build Diff
Build 29222: arc lint + arc unit

Event Timeline

Running npm start with css-loader 5.0.1:

deadalnix requested changes to this revision.Thu, Jan 7, 14:41

1/ I cannot reproduce, npm start works just fine on master.
2/ Knowing what the error is would help assert if the solution is appropriate.

This revision now requires changes to proceed.Thu, Jan 7, 14:41

Can you confirm issue is not repeatable after these steps to ensure installed dependencies match latest master?

cd web/cashtab
rm -rf node_modules
rm package-lock.json
npm i
npm start

Marco able to see same css break.

Many breaking changes from css-loader from 3.6 to 4.0; likely our downgraded webpack only supports up to 3.6

On master, removing node_modules and doing another npm install, I get the same errors reported above: