Paths

Table of Contentst

css-loader to highest version without breaking npm start
AbandonedPublic
Actions

Authored by bytesofman on Jan 7 2021, 13:38.

Details

Reviewers

alcipir
majcosta
deadalnix

Group Reviewers

Restricted Project

Summary

css-loader above 3.6.0 breaks css on npm start

Test Plan

npm i
npm start

Observe Cashtab loads with correct css

Diff Detail

Repository

rABC Bitcoin ABC

Branch

css-loader-downgrade

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14632
Build 29223: Build Diff
Build 29222: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 7 2021, 13:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2021, 13:38

bytesofman requested review of this revision.Jan 7 2021, 13:38

Harbormaster completed remote builds in B14632: Diff 26736.Jan 7 2021, 13:39

Running npm start with css-loader 5.0.1:

1/ I cannot reproduce, npm start works just fine on master.
2/ Knowing what the error is would help assert if the solution is appropriate.

This revision now requires changes to proceed.Jan 7 2021, 14:41

Can you confirm issue is not repeatable after these steps to ensure installed dependencies match latest master?

cd web/cashtab
rm -rf node_modules
rm package-lock.json
npm i
npm start

Marco able to see same css break.

Many breaking changes from css-loader from 3.6 to 4.0; likely our downgraded webpack only supports up to 3.6

On master, removing node_modules and doing another npm install, I get the same errors reported above:

Screen Shot 2021-01-07 at 11.49.09.png (1×1 px, 318 KB)

Fabien mentioned this in D8841: [cashtab] Downgrade css-loader.Jan 7 2021, 22:16

Abandoned / resolved by D8841

Revision Contents
Changeset List

Path

Size

web/

cashtab/

package-lock.json

446 lines

package.json

2 lines

Diff 26736

View Options

web/cashtab/package-lock.json