Differential D8643

test: Pass ArgsManager into getarg_tests
ClosedPublic
Actions

Authored by Fabien on Dec 10 2020, 11:03.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCd0e6cf718672: test: Pass ArgsManager into getarg_tests

Summary

Replaced the global argsManager gArgs with a locally defined one in
getarg_tests. This is to avoid confusion in arg settings between the
test's ArgsManager and the #18804

Backport of core PR18926.

This overrides the changes from D4462 which achieved the same goal.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 10 2020, 11:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2020, 11:04

Fabien requested review of this revision.Dec 10 2020, 11:04

teamcity edited the summary of this revision. (Show Details)Dec 10 2020, 11:04

Harbormaster completed remote builds in B14367: Diff 26301.Dec 10 2020, 11:18

Fabien added a child revision: D8644: refactor: Pass ArgsManager into functions that register args.Dec 10 2020, 13:15

majcosta accepted this revision.Dec 10 2020, 15:09

This revision is now accepted and ready to land.Dec 10 2020, 15:09

Closed by commit rABCd0e6cf718672: test: Pass ArgsManager into getarg_tests (authored by glowang, committed by Fabien). · Explain WhyDec 10 2020, 18:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd0e6cf718672: test: Pass ArgsManager into getarg_tests.

Revision Contents
Changeset List

Path

Size

src/

test/

getarg_tests.cpp

224 lines

Diff 26309

View Options

test: Pass ArgsManager into getarg_testsClosedPublicActions