Differential D8658

refactor: Fix unreachable code in init arg checks (part 2)
ClosedPublic
Actions

Authored by Fabien on Dec 10 2020, 23:58.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABCe27d9b655a1e: refactor: Fix unreachable code in init arg checks (part 2)

Summary

Follow-up for rABC6c84fca7a26eee3f5f031f02610d4528f7ef8276
which lost the changes for an unknown reason.

Backport of core PR19131.

Test Plan

With Werror enabled:

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19131

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14385
Build 28745: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28744: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 10 2020, 23:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2020, 23:58

Fabien requested review of this revision.Dec 10 2020, 23:58

teamcity edited the summary of this revision. (Show Details)Dec 10 2020, 23:59

jasonbcox accepted this revision.Dec 11 2020, 00:03

This revision is now accepted and ready to land.Dec 11 2020, 00:03

This revision was landed with ongoing or failed builds.Dec 11 2020, 00:04

Closed by commit rABCe27d9b655a1e: refactor: Fix unreachable code in init arg checks (part 2) (authored by Jonathan Schoeller <jonathan.schoeller@rea-group.com>, committed by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe27d9b655a1e: refactor: Fix unreachable code in init arg checks (part 2).

Harbormaster completed remote builds in B14385: Diff 26324.Dec 11 2020, 00:19

Revision Contents
Changeset List

Path

Size

src/

init.cpp

26 lines

Diff 26324

View Options

refactor: Fix unreachable code in init arg checks (part 2)ClosedPublicActions