Make uploading the assets optional when creating a release draft
ClosedPublic
Actions

Authored by Fabien on Dec 15 2020, 09:01.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCc7aa1518e5bb: Make uploading the assets optional when creating a release draft

Summary

Since we support both BCHA and BCHN, we stopped uploading the assets to
the github release page. This diffs makes the asset directory optional
when using the github-release.sh script to reflect this behavior.

Test Plan

Was used to create the 0.22.9 draft:
https://github.com/Bitcoin-ABC/bitcoin-abc/releases/tag/untagged-5d8c9a02a8eb88114b7e

Diff Detail

Repository

rABC Bitcoin ABC

Branch

github_draft_no_asset

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14411
Build 28791: Build Diff
Build 28790: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 15 2020, 09:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 15 2020, 09:01

Fabien requested review of this revision.Dec 15 2020, 09:01

Harbormaster completed remote builds in B14411: Diff 26376.Dec 15 2020, 09:01

that link is a 404 for me

majcosta accepted this revision.Dec 15 2020, 12:51

This revision is now accepted and ready to land.Dec 15 2020, 12:51

Closed by commit rABCc7aa1518e5bb: Make uploading the assets optional when creating a release draft (authored by Fabien). · Explain WhyDec 15 2020, 12:55

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc7aa1518e5bb: Make uploading the assets optional when creating a release draft.

Revision Contents
Changeset List

Path

Size

contrib/

release/

github-release.sh

60 lines

Diff 26376

View Options

contrib/release/github-release.sh

Make uploading the assets optional when creating a release draftClosedPublicActions