gui: Add transactionClicked and coinsSent signals to WalletView
ClosedPublic
Actions

Authored by PiRK on Dec 18 2020, 14:35.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCf36cdc7e0c85: gui: Add transactionClicked and coinsSent signals to WalletView

Summary

Two new signals are added beforehand in the first commit so that the connections in WalletFrame are all from the wallet view.

This is a backport of Core PR17937 [1/2]
https://github.com/bitcoin/bitcoin/pull/17937/commits/ac3d10777d65b68862c6deb57594c8fc4d21ca77

Test Plan

ninja && src/qt/bitcoin-qt
Send a transaction, check that the transaction history page is automatically selected

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 18 2020, 14:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 18 2020, 14:35

PiRK requested review of this revision.Dec 18 2020, 14:35

teamcity edited the summary of this revision. (Show Details)Dec 18 2020, 14:35

PiRK added a child revision: D8699: gui: Remove WalletView and BitcoinGUI circular dependency.Dec 18 2020, 14:39

Harbormaster completed remote builds in B14446: Diff 26428.Dec 18 2020, 14:45

majcosta accepted this revision.Dec 18 2020, 19:03

This revision is now accepted and ready to land.Dec 18 2020, 19:03

Closed by commit rABCf36cdc7e0c85: gui: Add transactionClicked and coinsSent signals to WalletView (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhyDec 18 2020, 19:33

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf36cdc7e0c85: gui: Add transactionClicked and coinsSent signals to WalletView.

Revision Contents
Changeset List

Path

Size

src/

qt/

walletview.h

2 lines

walletview.cpp

8 lines

Diff 26438

View Options

src/qt/walletview.h