Differential D8700

doc: address pr17578 review feedback
ClosedPublic
Actions

Authored by PiRK on Dec 18 2020, 16:39.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC0eed7c672ca4: doc: address pr17578 review feedback

Summary

Comments and docstring changes only

https://github.com/bitcoin/bitcoin/pull/17578#discussion_r363969721

https://github.com/bitcoin/bitcoin/pull/17578#discussion_r362703553

This is a backport of Core PR17585 [1/5]
https://github.com/bitcoin/bitcoin/pull/17585/commits/c7654af6f830577a54df12b5d65df93532db0dc2

Test Plan

proof reading

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14448
Build 28863: Build Diff	build-diff · build-clang · lint-circular-dependencies · build-debug · build-without-wallet · build-clang-tidy
Build 28862: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 18 2020, 16:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 18 2020, 16:39

PiRK requested review of this revision.Dec 18 2020, 16:39

teamcity edited the summary of this revision. (Show Details)Dec 18 2020, 16:39

Harbormaster completed remote builds in B14448: Diff 26431.Dec 18 2020, 16:52

majcosta accepted this revision.Dec 18 2020, 19:18

This revision is now accepted and ready to land.Dec 18 2020, 19:18

Closed by commit rABC0eed7c672ca4: doc: address pr17578 review feedback (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyDec 18 2020, 19:35

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC0eed7c672ca4: doc: address pr17578 review feedback.

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

5 lines

test/

functional/

rpc_getaddressinfo_labels_purpose_deprecation.py

4 lines

Diff 26431

View Options

src/wallet/rpcwallet.cpp