Page MenuHomePhabricator
Differential D8712

[net/refactor] Introduce an enum to distinguish type of connection
ClosedPublic
Actions

Authored by Fabien on Dec 21 2020, 11:04.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC63c2381bcc75: [net/refactor] Introduce an enum to distinguish type of connection
Summary
- extract inbound & outbound types

Partial backport (2/19) of core PR19316:
https://github.com/bitcoin/bitcoin/pull/19316/commits/26304b4100201754fb32440bec3e3b78cd3f0e6d

Depends on D8711.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 21 2020, 11:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2020, 11:04
Fabien requested review of this revision.Dec 21 2020, 11:04
teamcity edited the summary of this revision. (Show Details)Dec 21 2020, 11:05
Fabien added a child revision: D8713: [net/refactor] Add manual connections to ConnectionType enum.Dec 21 2020, 11:12
Harbormaster completed remote builds in B14463: Diff 26458.Dec 21 2020, 11:19
Fabien edited the summary of this revision. (Show Details)Dec 21 2020, 11:39
Fabien edited the summary of this revision. (Show Details)Dec 21 2020, 12:49
Fabien added a parent revision: D8710: fuzz: Stop nodes in process_message* fuzzers.
Fabien updated this revision to Diff 26473.Dec 21 2020, 12:49
Fabien edited the summary of this revision. (Show Details)

Rebase on top of D8710

majcosta accepted this revision.Dec 21 2020, 12:58
This revision is now accepted and ready to land.Dec 21 2020, 12:58
Harbormaster completed remote builds in B14478: Diff 26473.Dec 21 2020, 13:13
Closed by commit rABC63c2381bcc75: [net/refactor] Introduce an enum to distinguish type of connection (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyDec 21 2020, 15:36
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC63c2381bcc75: [net/refactor] Introduce an enum to distinguish type of connection.

Revision Contents
Changeset List

PathSize
src/
avalanche/
test/
6 lines
8 lines
18 lines
test/
13 lines
fuzz/
2 lines
5 lines
12 lines

Diff 26485

View Options

src/avalanche/test/processor_tests.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/test/denialofservice_tests.cpp

Loading...
View Options

src/test/fuzz/process_message.cpp

Loading...
View Options

src/test/fuzz/process_messages.cpp

Loading...
View Options

src/test/net_tests.cpp

Loading...