qt: Fix deprecated QCharRef usage
ClosedPublic
Actions

Authored by PiRK on Dec 22 2020, 14:38.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC227a327fd98b: qt: Fix deprecated QCharRef usage

Summary

This change prevent a QCharRef deprecation warning if any modifier key is pressed while the spashscreen is still displayed, for Qt >= 5.14.
As a side effect, Ctrl+Q and Shift+Q will also close the splashscreen now.

This is a backport of core PR18101

Test Plan

ninja && src/qt/bitcoin-qt -regtest
Press Q, or Ctrl+Q or Shift+Q while on the splashscreen.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 22 2020, 14:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 22 2020, 14:38

PiRK requested review of this revision.Dec 22 2020, 14:38

teamcity edited the summary of this revision. (Show Details)Dec 22 2020, 14:38

Harbormaster completed remote builds in B14505: Diff 26528.Dec 22 2020, 15:07

Fabien accepted this revision.Dec 22 2020, 15:19

This revision is now accepted and ready to land.Dec 22 2020, 15:19

Closed by commit rABC227a327fd98b: qt: Fix deprecated QCharRef usage (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyDec 22 2020, 16:49

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC227a327fd98b: qt: Fix deprecated QCharRef usage.

Revision Contents
Changeset List

Path

Size

src/

qt/

splashscreen.cpp

2 lines

Diff 26534

View Options

qt: Fix deprecated QCharRef usageClosedPublicActions