Convert undo.h to new serialization framework
ClosedPublic
Actions

Authored by PiRK on Dec 22 2020, 16:23.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

Summary

Depends on D8744

There are some important differences in the deserialization, due to differences in how the Coin object is implemented (coins.h)

Test Plan

ninja all check-all

Repository

rABC Bitcoin ABC

Branch

pr18021

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14509
Build 28981: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28980: arc lint + arc unit

PiRK created this revision.Dec 22 2020, 16:23

PiRK requested review of this revision.Dec 22 2020, 16:23

PiRK edited the summary of this revision. (Show Details)Dec 22 2020, 16:25

PiRK added inline comments.Dec 22 2020, 16:28

src/undo.h
57	I am not entirely sure about this, because we are now using a reference to a `Coin` instead of a pointer. But all the tests seem to work, so I assume that it is possible to assign a brand new `Coin` instance to `pcoin`.

majcosta requested changes to this revision.Dec 22 2020, 19:28

majcosta added a subscriber: majcosta.

majcosta added inline comments.

src/undo.h
31	can we name this `txout` like in the source material?
41	same for this
55	is the `REF(...)` still needed?
57	this looks fine to me

This revision now requires changes to proceed.Dec 22 2020, 19:28

PiRK added inline comments.Dec 23 2020, 10:13

src/undo.h
41	In `Unser`, we use a local `CTxOut` variable named `txout`. I would find it confusing to call the `Coin` object `txout` and give another name to the `CTxOut` object.
55	I think I can remove it, now that `pcoin` is no longer const. I ran a few tests with and without, and confirmed it is not needed.
57	It obviously works according to tests, but I don't understand why. My understanding was that a reference must be initialized when it is declared and once a reference is initialized to a variable, it cannot be changed to refer to a variable object.