Page MenuHomePhabricator

[backport#16612] qt: Remove menu icons
ClosedPublic

Authored by majcosta on Dec 24 2020, 03:16.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCc7066157dac6: [backport#16612] qt: Remove menu icons
Summary

390874c722c5af0b37cb94151ffb49986eab5f7d qt: Remove menu icons (Wladimir J. van der Laan)

Pull request description:

Remove the icons from the application menu. Why remove?

- They are inconsistently applied, some actions had icons, some newer ones don't. Good luck coming up with a sensible icon for everything
- Menu icons don't seem to have a place in modern UI: for example, GNOME, MacOS have stopped showing these a long time ago (see https://github.com/bitcoin/bitcoin/pull/16584#issuecomment-521195090)
- Less bikeshedding opportunity about "what should the icon for this be"

Removed icons:

```
/icons/quit            res/icons/quit.png
/icons/about           res/icons/about.png
/icons/about_qt        res/icons/about_qt.png
/icons/options         res/icons/configure.png
/icons/key             res/icons/key.png
/icons/verify          res/icons/verify.png (also .svg)
/icons/debugwindow     res/icons/debugwindow.png
/icons/open            res/icons/open.png
/icons/info            res/icons/info.png
/icons/filesave        res/icons/filesave.png
```
I checked that these icons are used nowhere else.

Removed from the menu not removed from the repository, because still referenced by other parts of the code:
```
/icons/lock_closed
/icons/edit
/icons/address-book
/icons/send
```

Backport of Core PR16612

Test Plan
ninja all

run bitcoin-qt -regtest, check that icons are gone but everything else
is alright

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable