Differential D8752

[backport#17162] chain: Remove CBlockIndex::SetNull helper
ClosedPublic
Actions

Authored by majcosta on Dec 24 2020, 04:30.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCca7abed8bb6c: [backport#17162] chain: Remove CBlockIndex::SetNull helper

Summary

fa0467326ff004a0a20c6af9c8f6adcc74a0c8af chain: Set all CBlockIndex members to null, remove SetNull helper (MarcoFalke)

Pull request description:

The first commit removes the `SetNull` helper and inlines the member initialization (C++11). See https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#c-data-structures for rationale.

<strike>The second commit adds the `cs_main` lock annotation to `RaiseValidity`. See also #17161.</strike>

Backport of Core PR17162

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Dec 24 2020, 04:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 24 2020, 04:30

majcosta requested review of this revision.Dec 24 2020, 04:30

teamcity edited the summary of this revision. (Show Details)Dec 24 2020, 04:31

majcosta edited the summary of this revision. (Show Details)Dec 24 2020, 04:32

Harbormaster completed remote builds in B14519: Diff 26552.Dec 24 2020, 04:51

PiRK accepted this revision.Dec 24 2020, 16:22

This revision is now accepted and ready to land.Dec 24 2020, 16:22

Closed by commit rABCca7abed8bb6c: [backport#17162] chain: Remove CBlockIndex::SetNull helper (authored by fanquake <fanquake@gmail.com>, committed by majcosta). · Explain WhyDec 24 2020, 16:26

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCca7abed8bb6c: [backport#17162] chain: Remove CBlockIndex::SetNull helper.

Revision Contents
Changeset List

Path

Size

src/

54 lines

Diff 26567

src/blockindex.h

Loading...