Differential D8780

Pass chain params explicitely to EncodeSecret and DecodeSecret
ClosedPublic
Actions

Authored by deadalnix on Jan 4 2021, 20:17.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC9290166fe3a2: Pass chain params explicitely to EncodeSecret and DecodeSecret

Summary

As per title. In general, we want to avoid snooping on global state implicitely.

Test Plan

Added unit tests for the new functions.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 4 2021, 20:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 4 2021, 20:17

deadalnix requested review of this revision.Jan 4 2021, 20:17

Harbormaster completed remote builds in B14557: Diff 26616.Jan 4 2021, 20:32

PiRK accepted this revision.Jan 5 2021, 08:40

This revision is now accepted and ready to land.Jan 5 2021, 08:40

Closed by commit rABC9290166fe3a2: Pass chain params explicitely to EncodeSecret and DecodeSecret (authored by deadalnix). · Explain WhyJan 6 2021, 00:04

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC9290166fe3a2: Pass chain params explicitely to EncodeSecret and DecodeSecret.

Revision Contents
Changeset List

Path

Size

src/

key_io.h

2 lines

key_io.cpp

12 lines

test/

key_tests.cpp

43 lines

Diff 26649

View Options

src/key_io.h

View Options

src/key_io.cpp

View Options

Pass chain params explicitely to EncodeSecret and DecodeSecretClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26649

src/key_io.h

src/key_io.cpp

src/test/key_tests.cpp

Pass chain params explicitely to EncodeSecret and DecodeSecret
ClosedPublic
Actions

Revision Contents
Changeset List