Paths

Table of Contentst

Differential D8783

[rpc] changed MineBlocksOnDemand to IsMockableChain
ClosedPublic
Actions

Authored by PiRK on Jan 5 2021, 10:39.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCaa3561df3367: [rpc] changed MineBlocksOnDemand to IsMockableChain

Summary

Change: Update the if statement in setmocktime to use IsMockableChain chainparams function (aka m_is_mockable_chain) instead of MineBlocksOnDemand

Rationale: It's a more appropriate check for whether or not chain is in RegTest, as discussed in PR18037

This is a backport of Core PR18263

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 5 2021, 10:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2021, 10:39

PiRK requested review of this revision.Jan 5 2021, 10:39

teamcity edited the summary of this revision. (Show Details)Jan 5 2021, 10:39

Harbormaster completed remote builds in B14564: Diff 26627.Jan 5 2021, 10:49

Fabien accepted this revision.Jan 5 2021, 12:16

Fabien edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Jan 5 2021, 12:17

Closed by commit rABCaa3561df3367: [rpc] changed MineBlocksOnDemand to IsMockableChain (authored by Gloria Zhao <gzhao408@berkeley.edu>, committed by PiRK). · Explain WhyJan 5 2021, 17:08

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCaa3561df3367: [rpc] changed MineBlocksOnDemand to IsMockableChain.

Revision Contents
Changeset List

Path

Size

src/

rpc/

2 lines

Diff 26640

src/rpc/misc.cpp

Loading...