Page MenuHomePhabricator
Differential D8788

Add DifferenceFormatter
ClosedPublic
Actions

Authored by PiRK on Jan 5 2021, 12:54.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC1be72a31df64: Add DifferenceFormatter
Summary

This is a backport of Core PR18112 [3/5]
https://github.com/bitcoin/bitcoin/pull/18112/commits/10633398f2dddf929d3f535aa48d138ad5e6c50f

Depends on D8787

Test Plan

ninja

Diff Detail

Event Timeline

PiRK created this revision.Jan 5 2021, 12:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2021, 12:54
PiRK requested review of this revision.Jan 5 2021, 12:54
teamcity edited the summary of this revision. (Show Details)Jan 5 2021, 12:54
PiRK added a child revision: D8789: Add CustomUintFormatter.Jan 5 2021, 12:56
Harbormaster completed remote builds in B14569: Diff 26632.Jan 5 2021, 13:22
majcosta requested changes to this revision.Jan 5 2021, 18:45
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/blockencodings.h
35–36

braces

43–46

braces

This revision now requires changes to proceed.Jan 5 2021, 18:45
PiRK updated this revision to Diff 26653.Jan 6 2021, 08:27

braces

majcosta accepted this revision.Jan 6 2021, 08:36
This revision is now accepted and ready to land.Jan 6 2021, 08:36
Harbormaster completed remote builds in B14585: Diff 26653.Jan 6 2021, 08:40
Closed by commit rABC1be72a31df64: Add DifferenceFormatter (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhyJan 6 2021, 08:58
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC1be72a31df64: Add DifferenceFormatter.

Revision Contents
Changeset List

PathSize
src/
21 lines

Diff 26632

View Options

src/blockencodings.h

Loading...