Page MenuHomePhabricator
Differential D8809

Downgrade react-test-renderer
ClosedPublic
Actions

Authored by deadalnix on Jan 6 2021, 22:29.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC3eb41051dc53: Downgrade react-test-renderer
Summary

The version used require react 17, but numerous other package support only react up to 16.

Test Plan

Observe there is one less conflict when upgrading

Diff Detail

Repository
rABC Bitcoin ABC
Branch
downgradereact-test-renderer
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14605
Build 29169: Build Diff
Build 29168: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 6 2021, 22:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2021, 22:29
deadalnix requested review of this revision.Jan 6 2021, 22:29
Harbormaster completed remote builds in B14605: Diff 26697.Jan 6 2021, 22:29
bytesofman requested changes to this revision.Jan 6 2021, 22:52
bytesofman added a subscriber: bytesofman.

Good change.

When I pull this down, it builds a version without the Path1899 migration -- so this seems to not be based on the latest master.

This revision now requires changes to proceed.Jan 6 2021, 22:52
deadalnix updated this revision to Diff 26699.Jan 6 2021, 23:51

rebase

Harbormaster completed remote builds in B14607: Diff 26699.Jan 6 2021, 23:52
bytesofman accepted this revision.Jan 7 2021, 00:31

Up and running

This revision is now accepted and ready to land.Jan 7 2021, 00:31
Closed by commit rABC3eb41051dc53: Downgrade react-test-renderer (authored by deadalnix). · Explain WhyJan 7 2021, 01:13
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC3eb41051dc53: Downgrade react-test-renderer.

Revision Contents
Changeset List

PathSize
web/
cashtab/
79 lines
2 lines

Diff 26697

View Options

web/cashtab/package-lock.json

Loading...
View Options

web/cashtab/package.json

Loading...