Page MenuHomePhabricator

Fix missing header in sync.h
ClosedPublic

Authored by PiRK on Fri, Jan 8, 07:36.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf602c2627c0c: Fix missing header in sync.h
Summary

std::string is referenced in sync.h but the relevant header is not explicitly included as required by current guideline. Furthermore on osx 10.14.6 with clang-900.0.31 the following error occurs:

In file included from threadinterrupt.cpp:6:
In file included from ./threadinterrupt.h:8:
./sync.h:206:21: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
        std::string lockname;

This is a backport of Core PR18357

Test Plan

ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.