HomePhabricator

Fix missing header in sync.h

Description

Fix missing header in sync.h

Summary:

std::string is referenced in sync.h but the relevant header is not explicitly included as required by current guideline. Furthermore on osx 10.14.6 with clang-900.0.31 the following error occurs:

In file included from threadinterrupt.cpp:6:
In file included from ./threadinterrupt.h:8:
./sync.h:206:21: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
        std::string lockname;

This is a backport of Core PR18357

Test Plan: ninja

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8843

Details

Provenance
João Barbosa <joao.paulo.barbosa@gmail.com>Authored on Jan 8 2021, 10:27
PiRKCommitted on Jan 8 2021, 10:27
abc-botPushed on Jan 8 2021, 10:33
Reviewer
Restricted Project
Differential Revision
D8843: Fix missing header in sync.h
Parents
rABCb56c6036cd0b: [CI] Generate coverage reports for cashtab
Branches
Unknown
Tags
Unknown