Page MenuHomePhabricator

rpc: Document an RPCResult for all calls; Enforce at compile time
ClosedPublic

Authored by PiRK on Fri, Jan 8, 10:15.

Details

Summary

Also remove unneeded whitespaces in rpcwallet.cpp

This is a backport of Core PR18346

Test Plan
ninja all check-all
grep -R ../RPCResults

Display the help message for some commands (e.g. src/bitcoin-cli help getavalanchekey)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Fri, Jan 8, 10:15
PiRK edited the test plan for this revision. (Show Details)

Failed tests logs:

====== Bitcoin ABC functional tests with the next upgrade activated: mempool_packages.py ======

------- Stdout: -------
2021-01-08T10:33:43.907000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210108_103159/mempool_packages_261
2021-01-08T10:33:50.684000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 120, in main
    self.run_test()
  File "/work/test/functional/mempool_packages.py", line 299, in run_test
    assert tx in mempool1
AssertionError
2021-01-08T10:33:50.734000Z TestFramework (INFO): Stopping nodes
2021-01-08T10:33:50.986000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210108_103159/mempool_packages_261
2021-01-08T10:33:50.986000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210108_103159/mempool_packages_261/test_framework.log
2021-01-08T10:33:50.986000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210108_103159/mempool_packages_261' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests with the next upgrade activated: mempool_packages.py

deadalnix requested changes to this revision.Fri, Jan 8, 11:06
deadalnix added a subscriber: deadalnix.

Check build failure

This revision now requires changes to proceed.Fri, Jan 8, 11:06
PiRK edited the test plan for this revision. (Show Details)

rebase after landing D8851

This revision is now accepted and ready to land.Fri, Jan 8, 16:28