rpc: Document an RPCResult for all calls; Enforce at compile time
ClosedPublic
Actions

Authored by PiRK on Jan 8 2021, 10:15.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC29659c3c45ee: rpc: Document an RPCResult for all calls; Enforce at compile time

Summary

Also remove unneeded whitespaces in rpcwallet.cpp

This is a backport of Core PR18346

Test Plan

ninja all check-all
grep -R ../RPCResults

Display the help message for some commands (e.g. src/bitcoin-cli help getavalanchekey)

Diff Detail

Repository

rABC Bitcoin ABC

Branch

arcpatch-D8845

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14670
Build 29299: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 29298: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 8 2021, 10:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 8 2021, 10:15

PiRK requested review of this revision.Jan 8 2021, 10:15

teamcity edited the summary of this revision. (Show Details)Jan 8 2021, 10:16

PiRK edited the summary of this revision. (Show Details)Jan 8 2021, 10:24

PiRK edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B14658: Diff 26780.Jan 8 2021, 10:37

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests with the next upgrade activated: mempool_packages.py ======

------- Stdout: -------
2021-01-08T10:33:43.907000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210108_103159/mempool_packages_261
2021-01-08T10:33:50.684000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 120, in main
    self.run_test()
  File "/work/test/functional/mempool_packages.py", line 299, in run_test
    assert tx in mempool1
AssertionError
2021-01-08T10:33:50.734000Z TestFramework (INFO): Stopping nodes
2021-01-08T10:33:50.986000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210108_103159/mempool_packages_261
2021-01-08T10:33:50.986000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210108_103159/mempool_packages_261/test_framework.log
2021-01-08T10:33:50.986000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210108_103159/mempool_packages_261' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests with the next upgrade activated: mempool_packages.py