Page MenuHomePhabricator

test: listsinceblock block height checks
ClosedPublic

Authored by PiRK on Wed, Jan 13, 10:06.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC78de14facc83: test: listsinceblock block height checks
Summary

This PR extends a listsinceblock test to check the new transaction 'blockheight' field recently added in PR17437. It also cleans up code in the test function without changing or removing existing checks.

This is a backport of Core PR18420

Test Plan

ninja && test/functional/test_runner.py wallet_listsinceblock

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Wed, Jan 13, 10:07

Tail of the build log:

[375/434] bitcoin: testing finalization_tests
[376/434] bitcoin: testing merkleblock_tests
[377/434] bitcoin: testing script_commitment_tests
[378/434] bitcoin: testing sighashtype_tests
[379/434] Running utility command for check-bitcoin-finalization_tests
[380/434] Running utility command for check-bitcoin-merkleblock_tests
[381/434] Running utility command for check-bitcoin-script_commitment_tests
[382/434] Running utility command for check-bitcoin-sighashtype_tests
[383/434] bitcoin: testing bip32_tests
[384/434] Running utility command for check-bitcoin-bip32_tests
[385/434] bitcoin: testing settings_tests
[386/434] bitcoin: testing timedata_tests
[387/434] Running utility command for check-bitcoin-settings_tests
[388/434] Running utility command for check-bitcoin-timedata_tests
[389/434] bitcoin: testing streams_tests
[390/434] bitcoin: testing uint256_tests
[391/434] Running utility command for check-bitcoin-streams_tests
[392/434] Running utility command for check-bitcoin-uint256_tests
[393/434] bitcoin: testing undo_tests
[394/434] Running utility command for check-bitcoin-undo_tests
[395/434] bitcoin: testing util_threadnames_tests
[396/434] bitcoin: testing walletdb_tests
[397/434] Running utility command for check-bitcoin-util_threadnames_tests
[398/434] Running utility command for check-bitcoin-walletdb_tests
[399/434] bitcoin: testing validation_chainstatemanager_tests
[400/434] Running utility command for check-bitcoin-validation_chainstatemanager_tests
[401/434] bitcoin: testing validationinterface_tests
[402/434] bitcoin: testing txvalidationcache_tests
[403/434] Running utility command for check-bitcoin-validationinterface_tests
[404/434] bitcoin: testing serialize_tests
[405/434] Running utility command for check-bitcoin-txvalidationcache_tests
[406/434] Running utility command for check-bitcoin-serialize_tests
[407/434] bitcoin: testing cashaddr_tests
[408/434] Running utility command for check-bitcoin-cashaddr_tests
[409/434] bitcoin: testing getarg_tests
[410/434] bitcoin: testing radix_tests
[411/434] Running utility command for check-bitcoin-getarg_tests
[412/434] Running utility command for check-bitcoin-radix_tests
[413/434] bitcoin: testing schnorr_tests
[414/434] Running utility command for check-bitcoin-schnorr_tests
[415/434] bitcoin: testing crypto_tests
[416/434] Running utility command for check-bitcoin-crypto_tests
[417/434] bitcoin: testing util_tests
[418/434] Running utility command for check-bitcoin-util_tests
[419/434] bitcoin: testing monolith_opcodes_tests
[420/434] Running utility command for check-bitcoin-monolith_opcodes_tests
[421/434] bitcoin: testing script_tests
[422/434] Running utility command for check-bitcoin-script_tests
[423/434] bitcoin: testing transaction_tests
[424/434] Running utility command for check-bitcoin-transaction_tests
[425/434] bitcoin: testing cuckoocache_tests
[426/434] Running utility command for check-bitcoin-cuckoocache_tests
[427/434] bitcoin: testing skiplist_tests
[428/434] Running utility command for check-bitcoin-skiplist_tests
[429/434] bitcoin: testing coins_tests
[430/434] bitcoin: testing op_reversebytes_tests
[431/434] Running utility command for check-bitcoin-coins_tests
[432/434] Running utility command for check-bitcoin-op_reversebytes_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/wallet_listsinceblock.py
126 ↗(On Diff #26901)
This revision is now accepted and ready to land.Wed, Jan 13, 11:11

use ABC commit/revision ID in comment

This revision was automatically updated to reflect the committed changes.