HomePhabricator

test: listsinceblock block height checks

Description

test: listsinceblock block height checks

Summary:

This PR extends a listsinceblock test to check the new transaction 'blockheight' field recently added in PR17437. It also cleans up code in the test function without changing or removing existing checks.

This is a backport of Core PR18420

Test Plan: ninja && test/functional/test_runner.py wallet_listsinceblock

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8895

Details

Provenance
Jon Atack <jon@atack.com>Authored on Jan 13 2021, 13:50
PiRKCommitted on Jan 13 2021, 13:51
abc-botPushed on Jan 13 2021, 13:57
Reviewer
Restricted Project
Differential Revision
D8895: test: listsinceblock block height checks
Parents
rABC3ba6c6af6eb9: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged
Branches
Unknown
Tags
Unknown