Page MenuHomePhabricator

rpc: Remove deprecated migration code
ClosedPublic

Authored by PiRK on Jan 14 2021, 16:31.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCfe5862ed7191: rpc: Remove deprecated migration code
Summary

Don't accept a second argument to sendrawtransaction and
testmempoolaccept of type bool. Actually even the code before this
change would not accept bool, but it would print a long explanatory
message when rejecting it: "Second argument must be numeric (maxfeerate)
and no longer supports a boolean. To allow a transaction with high fees,
set maxfeerate to 0."

This was scheduled for removal in rABC1d4e5281a755

This is a backport of Core PR18495

Test Plan

ninja all check-all

src/bitcoin-cli help testmempoolaccept
src/bitcoin-cli help sendrawtransaction

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.