HomePhabricator

cli -getinfo: use getbalances instead of deprecated getwalletinfo balance

Description

cli -getinfo: use getbalances instead of deprecated getwalletinfo balance

Summary:

This PR updates bitcoin-cli -getinfo to fetch the wallet balance from getbalances in order to no longer depend on getwalletinfo.balance which was deprecated a year ago in D6447

test: update and harden interface_bitcoin_cli tests

  • no longer depend on the deprecated balance field of getwalletinfo
  • test blockcount and balance against non-default, non-zero expected values

This is a backport of Core PR18574

Test Plan:
ninja all check-all
src/bitcoin-cli -getinfo

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Subscribers: majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8912

Details

Provenance
Jon Atack <jon@atack.com>Authored on Jan 14 2021, 16:18
PiRKCommitted on Jan 14 2021, 16:19
abc-botPushed on Jan 14 2021, 16:25
Reviewer
Restricted Project
Differential Revision
D8912: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance
Parents
rABC6620ec6c59e6: rpc: Make verifychain default values static, not depend on global args
Branches
Unknown
Tags
Unknown