Differential D6447

[backport#15930] rpc: Deprecate getunconfirmedbalance and getwalletinfo balances
ClosedPublic
Actions

Authored by majcosta on Jun 7 2020, 20:21.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC0eddb715c412: [backport#15930] rpc: Deprecate getunconfirmedbalance and getwalletinfo balances

Summary

https://github.com/bitcoin/bitcoin/pull/15930/commits/facfb4111d14a3b06c46690a2cca7ca91cea8a96

Depends on D6446

Concludes backport of Core PR15930

Test Plan

ninja
./src/bitcoind -regtest -daemon
./src/bitcoin-cli -regtest getunconfirmedbalance help
./src/bitcoin-cli -regtest getwalletinfo help

Check if it looks good

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 7 2020, 20:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2020, 20:21

majcosta requested review of this revision.Jun 7 2020, 20:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11303: Diff 21053.Jun 7 2020, 20:31

deadalnix accepted this revision.Jun 7 2020, 20:54

This revision is now accepted and ready to land.Jun 7 2020, 20:54

Closed by commit rABC0eddb715c412: [backport#15930] rpc: Deprecate getunconfirmedbalance and getwalletinfo balances (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJun 9 2020, 16:37

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC0eddb715c412: [backport#15930] rpc: Deprecate getunconfirmedbalance and getwalletinfo balances.

PiRK mentioned this in D8912: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.Jan 14 2021, 12:29

PiRK mentioned this in rABCe5977fde2198: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.Jan 14 2021, 16:25

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

9 lines

src/

wallet/

rpcwallet.cpp

14 lines

Diff 21153

View Options

doc/release-notes.md