Page MenuHomePhabricator

[backport#15930] wallet: Use IsValidNumArgs in getwalletinfo rpc
ClosedPublic

Authored by majcosta on Jun 7 2020, 20:00.

Details

Summary
Test Plan
ninja
./src/bitcoind -regtest -daemon
./src/bitcoin-cli getwalletinfo help

check that it looks alright

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta requested review of this revision.Jun 7 2020, 20:00

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Jun 7 2020, 20:24
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/wallet/rpcwallet.cpp
2902 ↗(On Diff #21050)

You want to relayout because a few of these like this one could probably fit on one line now.

This revision now requires changes to proceed.Jun 7 2020, 20:24
This revision is now accepted and ready to land.Jun 7 2020, 20:48