Page MenuHomePhabricator
Differential D6444

[backport#15930] wallet: Use IsValidNumArgs in getwalletinfo rpc
ClosedPublic
Actions

Authored by majcosta on Jun 7 2020, 20:00.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCbb39798e5b9f: [backport#15930] wallet: Use IsValidNumArgs in getwalletinfo rpc
Summary

https://github.com/bitcoin/bitcoin/pull/15930/commits/fad40ec9151248c6e8225e14980424f581d23e02

Depends on D6443

Partial backport of Core PR15930

Test Plan
ninja
./src/bitcoind -regtest -daemon
./src/bitcoin-cli getwalletinfo help

check that it looks alright

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 7 2020, 20:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2020, 20:00
majcosta requested review of this revision.Jun 7 2020, 20:00
teamcity edited the summary of this revision. (Show Details)Jun 7 2020, 20:00

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6445: [backport#15930] rpcwallet: Make helper methods const on CWallet.Jun 7 2020, 20:05
Harbormaster completed remote builds in B11300: Diff 21050.Jun 7 2020, 20:09
deadalnix requested changes to this revision.Jun 7 2020, 20:24
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/wallet/rpcwallet.cpp
2902 ↗(On Diff #21050)

You want to relayout because a few of these like this one could probably fit on one line now.

This revision now requires changes to proceed.Jun 7 2020, 20:24
majcosta updated this revision to Diff 21054.Jun 7 2020, 20:46

relayout rpc help

deadalnix accepted this revision.Jun 7 2020, 20:48
This revision is now accepted and ready to land.Jun 7 2020, 20:48
Harbormaster completed remote builds in B11304: Diff 21054.Jun 7 2020, 20:56
Closed by commit rABCbb39798e5b9f: [backport#15930] wallet: Use IsValidNumArgs in getwalletinfo rpc (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJun 9 2020, 16:36
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCbb39798e5b9f: [backport#15930] wallet: Use IsValidNumArgs in getwalletinfo rpc.

Revision Contents
Changeset List

PathSize
src/
wallet/
103 lines

Diff 21150

View Options

src/wallet/rpcwallet.cpp

Loading...