Page MenuHomePhabricator
Differential D6440

[backport#15758] test: Add wallet_balance test for watchonly
ClosedPublic
Actions

Authored by majcosta on Jun 7 2020, 19:41.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC6d30026d43f8: [backport#15758] test: Add wallet_balance test for watchonly
Summary

https://github.com/bitcoin/bitcoin/pull/15758/commits/fa464e8211850eed1b31bf1723c9e02845dacba1

Partial backport of Core PR15758

Test Plan
./test/functional/test_runner.py wallet_balance

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 7 2020, 19:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2020, 19:41
majcosta requested review of this revision.Jun 7 2020, 19:41
teamcity edited the summary of this revision. (Show Details)Jun 7 2020, 19:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6441: [backport#15758] test: Add getunconfirmedbalance test with conflicts.Jun 7 2020, 19:43
Harbormaster completed remote builds in B11296: Diff 21046.Jun 7 2020, 19:51
deadalnix requested changes to this revision.Jun 7 2020, 20:53
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
test/functional/wallet_balance.py
14 ↗(On Diff #21046)

You can use ADDRESS_BCHREG_UNSPENDABLE and match the original material.

This revision now requires changes to proceed.Jun 7 2020, 20:53
majcosta updated this revision to Diff 21059.Jun 7 2020, 21:31

gave unspendable address a more congruent name with the change

Harbormaster completed remote builds in B11306: Diff 21059.Jun 7 2020, 21:40
deadalnix requested changes to this revision.Jun 8 2020, 13:50

You misunderstood. I meant

from test_framework.address import ADDRESS_BCHREG_UNSPENDABLE as ADDRESS_WATCHONLY

This revision now requires changes to proceed.Jun 8 2020, 13:50
majcosta updated this revision to Diff 21092.Jun 8 2020, 16:03

added the address used as watchonly to address.py to stay closer to original wallet_balance.py

Harbormaster completed remote builds in B11320: Diff 21092.Jun 8 2020, 16:16
majcosta planned changes to this revision.Jun 8 2020, 21:46
majcosta updated this revision to Diff 21124.EditedJun 8 2020, 22:06

this PR does not pass tests piecemeal, had to bring a change from the last commit into the first for that (line 20)

Harbormaster completed remote builds in B11340: Diff 21124.Jun 8 2020, 22:14
deadalnix accepted this revision.Jun 9 2020, 16:22
This revision is now accepted and ready to land.Jun 9 2020, 16:22
Closed by commit rABC6d30026d43f8: [backport#15758] test: Add wallet_balance test for watchonly (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJun 9 2020, 16:25
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC6d30026d43f8: [backport#15758] test: Add wallet_balance test for watchonly.

Revision Contents
Changeset List

PathSize
test/
functional/
31 lines

Diff 21146

View Options

test/functional/wallet_balance.py

Loading...