Page MenuHomePhabricator

[backport#15758] test: Add wallet_balance test for watchonly
ClosedPublic

Authored by majcosta on Jun 7 2020, 19:41.

Details

Summary
Test Plan
./test/functional/test_runner.py wallet_balance

Event Timeline

majcosta requested review of this revision.Jun 7 2020, 19:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Jun 7 2020, 20:53
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
test/functional/wallet_balance.py
14 ↗(On Diff #21046)

You can use ADDRESS_BCHREG_UNSPENDABLE and match the original material.

This revision now requires changes to proceed.Jun 7 2020, 20:53

gave unspendable address a more congruent name with the change

deadalnix requested changes to this revision.Jun 8 2020, 13:50

You misunderstood. I meant

from test_framework.address import ADDRESS_BCHREG_UNSPENDABLE as ADDRESS_WATCHONLY

This revision now requires changes to proceed.Jun 8 2020, 13:50

added the address used as watchonly to address.py to stay closer to original wallet_balance.py

this PR does not pass tests piecemeal, had to bring a change from the last commit into the first for that (line 20)

This revision is now accepted and ready to land.Jun 9 2020, 16:22