Page MenuHomePhabricator

cli -getinfo: use getbalances instead of deprecated getwalletinfo balance
ClosedPublic

Authored by PiRK on Jan 14 2021, 12:29.

Details

Summary

This PR updates bitcoin-cli -getinfo to fetch the wallet balance from getbalances in order to no longer depend on getwalletinfo.balance which was deprecated a year ago in D6447

test: update and harden interface_bitcoin_cli tests

  • no longer depend on the deprecated balance field of getwalletinfo
  • test blockcount and balance against non-default, non-zero expected values

This is a backport of Core PR18574

Test Plan

ninja all check-all
src/bitcoin-cli -getinfo

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Jan 14 2021, 12:29
majcosta requested changes to this revision.Jan 14 2021, 13:53
majcosta added a subscriber: majcosta.
majcosta added inline comments.
test/functional/interface_bitcoin_cli.py
95–97 ↗(On Diff #26951)

duplicated this line

This revision now requires changes to proceed.Jan 14 2021, 13:53

also "Backport of PR18574" is missing from summary

PiRK edited the summary of this revision. (Show Details)

deduplicate line and add PR number to revision

This revision is now accepted and ready to land.Jan 14 2021, 14:37