Page MenuHomePhabricator
Differential D8912

cli -getinfo: use getbalances instead of deprecated getwalletinfo balance
ClosedPublic
Actions

Authored by PiRK on Jan 14 2021, 12:29.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCe5977fde2198: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance
Summary

This PR updates bitcoin-cli -getinfo to fetch the wallet balance from getbalances in order to no longer depend on getwalletinfo.balance which was deprecated a year ago in D6447

test: update and harden interface_bitcoin_cli tests

  • no longer depend on the deprecated balance field of getwalletinfo
  • test blockcount and balance against non-default, non-zero expected values

This is a backport of Core PR18574

Test Plan

ninja all check-all
src/bitcoin-cli -getinfo

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 14 2021, 12:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 14 2021, 12:29
PiRK requested review of this revision.Jan 14 2021, 12:29
Harbormaster completed remote builds in B14765: Diff 26951.Jan 14 2021, 12:43
majcosta requested changes to this revision.Jan 14 2021, 13:53
majcosta added a subscriber: majcosta.
majcosta added inline comments.
test/functional/interface_bitcoin_cli.py
95–97 ↗(On Diff #26951)

duplicated this line

This revision now requires changes to proceed.Jan 14 2021, 13:53
majcosta added a comment.Jan 14 2021, 13:54

also "Backport of PR18574" is missing from summary

PiRK edited the summary of this revision. (Show Details)Jan 14 2021, 13:57
PiRK updated this revision to Diff 26959.Jan 14 2021, 14:00
PiRK edited the summary of this revision. (Show Details)

deduplicate line and add PR number to revision

Harbormaster completed remote builds in B14771: Diff 26959.Jan 14 2021, 14:15
majcosta accepted this revision.Jan 14 2021, 14:37
This revision is now accepted and ready to land.Jan 14 2021, 14:37
Closed by commit rABCe5977fde2198: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyJan 14 2021, 16:25
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe5977fde2198: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.

Revision Contents
Changeset List

PathSize
src/
15 lines
test/
functional/
21 lines

Diff 26972

View Options

src/bitcoin-cli.cpp

Loading...
View Options

test/functional/interface_bitcoin_cli.py

Loading...