Paths

Table of Contentst

Differential D8937

refactor: Remove unused methods CBloomFilter::reset()/clear()
ClosedPublic
Actions

Authored by PiRK on Jan 17 2021, 09:58.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC2f90a6e88129: refactor: Remove unused methods CBloomFilter::reset()/clear()

Summary

Co-authored-by: MarcoFalke <falke.marco@gmail.com>

The method CBloomFilter::reset() was introduced by commit d2d7ee0 in 2015, but was never ever used, as far as I could find. As discovered by MarcoFalke, the method clear() is also unused outside of unit tests and is hence also removed.

This is a backport of Core PR18670

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18670

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14811
Build 29576: Build Diff	build-without-wallet · build-debug · build-clang-tidy · lint-circular-dependencies · build-clang · build-diff
Build 29575: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 17 2021, 09:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2021, 09:58

PiRK requested review of this revision.Jan 17 2021, 09:58

teamcity edited the summary of this revision. (Show Details)Jan 17 2021, 09:58

Harbormaster completed remote builds in B14811: Diff 27025.Jan 17 2021, 10:11

majcosta accepted this revision.Jan 17 2021, 10:37

This revision is now accepted and ready to land.Jan 17 2021, 10:37

Closed by commit rABC2f90a6e88129: refactor: Remove unused methods CBloomFilter::reset()/clear() (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyJan 18 2021, 09:46

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2f90a6e88129: refactor: Remove unused methods CBloomFilter::reset()/clear().

Revision Contents
Changeset List

Path

Size

src/

3 lines

11 lines

test/

bloom_tests.cpp

7 lines

fuzz/

bloom_filter.cpp

13 lines

Diff 27025

src/bloom.h

Loading...

src/bloom.cpp

Loading...

src/test/bloom_tests.cpp

Loading...

src/test/fuzz/bloom_filter.cpp

Loading...