Page MenuHomePhabricator
Differential D8939

rpc: Add doc for deactivating settxfee and respect -maxtxfee wallet setting
ClosedPublic
Actions

Authored by PiRK on Jan 18 2021, 10:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC634c08afae92: rpc: Add doc for deactivating settxfee and respect -maxtxfee wallet setting
Summary

PR description:

settxfee can be deactivated by passing 0 as the fee. That does not seem to be documented for the user so this PR adds it in the description.
Added a commit that makes settxfee respect the setting -maxtxfee

This is a backport of Core PR18467

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 18 2021, 10:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2021, 10:20
PiRK requested review of this revision.Jan 18 2021, 10:20
teamcity edited the summary of this revision. (Show Details)Jan 18 2021, 10:21
PiRK updated this revision to Diff 27032.Jan 18 2021, 10:39

include the new functional test that the original PR added to wallet_bumpfee

I added it to rpc_estimatefee, next to the settxfee < mintxfee test

Harbormaster completed remote builds in B14815: Diff 27031.Jan 18 2021, 10:41
Harbormaster completed remote builds in B14816: Diff 27032.Jan 18 2021, 10:53
Fabien accepted this revision.Jan 18 2021, 16:49
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/rpc_estimatefee.py
44 ↗(On Diff #27032)

Macro likestamp:

This revision is now accepted and ready to land.Jan 18 2021, 16:49
Closed by commit rABC634c08afae92: rpc: Add doc for deactivating settxfee and respect -maxtxfee wallet setting (authored by Fabian Jahr <fjahr@protonmail.com>, committed by PiRK). · Explain WhyJan 18 2021, 21:51
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC634c08afae92: rpc: Add doc for deactivating settxfee and respect -maxtxfee wallet setting.

Revision Contents
Changeset List

PathSize
src/
wallet/
10 lines
test/
functional/
8 lines
5 lines

Diff 27054

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/rpc_estimatefee.py

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...