Page MenuHomePhabricator

rpc: Add doc for deactivating settxfee and respect -maxtxfee wallet setting
ClosedPublic

Authored by PiRK on Jan 18 2021, 10:20.

Details

Summary

PR description:

settxfee can be deactivated by passing 0 as the fee. That does not seem to be documented for the user so this PR adds it in the description.
Added a commit that makes settxfee respect the setting -maxtxfee

This is a backport of Core PR18467

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Jan 18 2021, 10:20

include the new functional test that the original PR added to wallet_bumpfee

I added it to rpc_estimatefee, next to the settxfee < mintxfee test

Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/rpc_estimatefee.py
44 ↗(On Diff #27032)

Macro likestamp:

This revision is now accepted and ready to land.Jan 18 2021, 16:49